From: Tom Tromey <tromey@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>, Tom Tromey <tromey@adacore.com>,
Simon Marchi <simark@simark.ca>,
Wadud Miah <wadud.miah@nag.co.uk>,
"gdb\@sourceware.org" <gdb@sourceware.org>
Subject: Re: building GDB 9.0.50.20191206
Date: Wed, 18 Dec 2019 20:23:00 -0000 [thread overview]
Message-ID: <87o8w5mlhe.fsf@tromey.com> (raw)
In-Reply-To: <20191217060047.GA3582@adacore.com> (Joel Brobecker's message of "Tue, 17 Dec 2019 10:00:47 +0400")
Joel> Going back to Simon's question about what to do for the release,
Joel> I tend to agree with you that it's an unnecessary risk to be trying
Joel> to finish the transition of moving the directories to the root
Joel> directory. Could we add a test that checks explicitly for in-tree
Joel> builds and abort with a clear error message when detected?
Sure. I don't know when I can get to it though.
Joel> Is there an in-tree/out-of-tree check that already exists for that?
Joel> Otherwise, I'd base it on the src_dir being different from the
Joel> build dir, but that's simple-minded and pretty easy to defeat
Joel> (not that it's a huge issue).
We could just check for any old source file in ".", like ChangeLog.
Or we could revert the gnulib move on the branch. That might not be too
hard.
Tom
next prev parent reply other threads:[~2019-12-18 20:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 10:47 Wadud Miah
2019-12-12 14:10 ` Joel Brobecker
2019-12-12 14:22 ` Wadud Miah
2019-12-13 19:53 ` Simon Marchi
2019-12-13 20:01 ` Tom Tromey
2019-12-13 20:21 ` Simon Marchi
2019-12-13 23:25 ` Tom Tromey
2019-12-15 16:17 ` Tom Tromey
2019-12-17 6:01 ` Joel Brobecker
2019-12-18 20:23 ` Tom Tromey [this message]
2019-12-14 17:29 ` Christian Biesinger via gdb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8w5mlhe.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=brobecker@adacore.com \
--cc=gdb@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
--cc=wadud.miah@nag.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox