From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82456 invoked by alias); 18 Dec 2019 20:23:29 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 82447 invoked by uid 89); 18 Dec 2019 20:23:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=Going, Joel, joel, simons X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2019 20:23:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DF63B56024; Wed, 18 Dec 2019 15:23:26 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Kwy0YMJpzYP1; Wed, 18 Dec 2019 15:23:26 -0500 (EST) Received: from murgatroyd (unknown [IPv6:2620:20:4000:100::1001]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 42F55116134; Wed, 18 Dec 2019 15:23:26 -0500 (EST) From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , Tom Tromey , Simon Marchi , Wadud Miah , "gdb\@sourceware.org" Subject: Re: building GDB 9.0.50.20191206 References: <20191212140954.GC8591@adacore.com> <878sngvvub.fsf@tromey.com> <986c3939-b6fd-b973-0ccb-1bd91f097df2@simark.ca> <871rt7vme9.fsf@tromey.com> <87h821ef6w.fsf@tromey.com> <20191217060047.GA3582@adacore.com> Date: Wed, 18 Dec 2019 20:23:00 -0000 In-Reply-To: <20191217060047.GA3582@adacore.com> (Joel Brobecker's message of "Tue, 17 Dec 2019 10:00:47 +0400") Message-ID: <87o8w5mlhe.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00034.txt.bz2 Joel> Going back to Simon's question about what to do for the release, Joel> I tend to agree with you that it's an unnecessary risk to be trying Joel> to finish the transition of moving the directories to the root Joel> directory. Could we add a test that checks explicitly for in-tree Joel> builds and abort with a clear error message when detected? Sure. I don't know when I can get to it though. Joel> Is there an in-tree/out-of-tree check that already exists for that? Joel> Otherwise, I'd base it on the src_dir being different from the Joel> build dir, but that's simple-minded and pretty easy to defeat Joel> (not that it's a huge issue). We could just check for any old source file in ".", like ChangeLog. Or we could revert the gnulib move on the branch. That might not be too hard. Tom