From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb@sourceware.org
Subject: Re: GSoC
Date: Thu, 09 Feb 2017 18:59:00 -0000 [thread overview]
Message-ID: <871sv76vik.fsf@tromey.com> (raw)
In-Reply-To: <09b20ae4ac80cf2958ec873b83379862@polymtl.ca> (Simon Marchi's message of "Thu, 09 Feb 2017 10:47:54 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> Well first of all, what is your idea of how the coloring should be?
I was more focused on infrastructure, not the defaults. So I just left
it all to the user. In fact my branch doesn't actually even have the
colorizing code, just the Python ui-out stuff; I have a separate .py
file that I use for experimenting.
Now that I look at that file again I do see a wrap_hint method, so maybe
the wrapping wasn't really a problem like I'd thought. Hard to recall.
Also I see I didn't even really try to implement "set color" in this
code, so I must have just been changing the Python by hand. Haha.
If you want to see the branch I can push it.
Simon> http://nova.polymtl.ca/~simark/ssg/filemC7ZUZ.png
Looks nice.
>> And, finally, for something like "set color", there's no good way to
>> implement completion because there isn't a list of the table- and
>> column-names. This could be done by introducing enums or something
>> like
>> that, but at that point the patch is going to be beyond what I would
>> want to commit to.
Simon> I don't understand this part. Which tables/columns?
My approach is based on reusing ui-out stuff, the idea being to
associate a color with the ui-out table (or tuple or list) name and the
field name.
I suppose this wouldn't actually work for value printing, since that
doesn't use ui-out. So maybe some other design is needed; or maybe
value printing needs to be changed a bit.
Tom
next prev parent reply other threads:[~2017-02-09 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 21:00 GSoC Simon Marchi
2017-02-07 21:40 ` GSoC Phil Muldoon
2017-02-07 22:11 ` GSoC Simon Marchi
2017-02-07 21:41 ` GSoC Jose E. Marchesi
2017-02-07 22:13 ` GSoC Simon Marchi
2017-02-08 17:12 ` GSoC Tom Tromey
2017-02-09 15:48 ` GSoC Simon Marchi
2017-02-09 18:59 ` Tom Tromey [this message]
2017-02-09 21:35 ` GSoC Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sv76vik.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox