From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9545 invoked by alias); 9 Feb 2017 18:59:15 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 9534 invoked by uid 89); 9 Feb 2017 18:59:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_05,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=UD:polymtl.ca, simark, novapolymtlca, ssg X-HELO: gproxy2-pub.mail.unifiedlayer.com Received: from gproxy2-pub.mail.unifiedlayer.com (HELO gproxy2-pub.mail.unifiedlayer.com) (69.89.18.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 09 Feb 2017 18:59:04 +0000 Received: (qmail 24852 invoked by uid 0); 9 Feb 2017 18:59:03 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy2.mail.unifiedlayer.com with SMTP; 9 Feb 2017 18:59:03 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id iiz01u00T2f2jeq01iz3FW; Thu, 09 Feb 2017 11:59:03 -0700 X-Authority-Analysis: v=2.1 cv=WOnsABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=_ZhYKdCeAAAA:8 a=BV2rlhVRbitE_ovhGB8A:9 a=uqOk3ZSnBfCTOznnrPA1:22 Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:48012 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cbtvo-0007F4-AA; Thu, 09 Feb 2017 11:59:00 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb@sourceware.org Subject: Re: GSoC References: <87k2907gk7.fsf@tromey.com> <09b20ae4ac80cf2958ec873b83379862@polymtl.ca> Date: Thu, 09 Feb 2017 18:59:00 -0000 In-Reply-To: <09b20ae4ac80cf2958ec873b83379862@polymtl.ca> (Simon Marchi's message of "Thu, 09 Feb 2017 10:47:54 -0500") Message-ID: <871sv76vik.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cbtvo-0007F4-AA X-Source-Sender: 174-16-146-181.hlrn.qwest.net (pokyo) [174.16.146.181]:48012 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-02/txt/msg00022.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Well first of all, what is your idea of how the coloring should be? I was more focused on infrastructure, not the defaults. So I just left it all to the user. In fact my branch doesn't actually even have the colorizing code, just the Python ui-out stuff; I have a separate .py file that I use for experimenting. Now that I look at that file again I do see a wrap_hint method, so maybe the wrapping wasn't really a problem like I'd thought. Hard to recall. Also I see I didn't even really try to implement "set color" in this code, so I must have just been changing the Python by hand. Haha. If you want to see the branch I can push it. Simon> http://nova.polymtl.ca/~simark/ssg/filemC7ZUZ.png Looks nice. >> And, finally, for something like "set color", there's no good way to >> implement completion because there isn't a list of the table- and >> column-names. This could be done by introducing enums or something >> like >> that, but at that point the patch is going to be beyond what I would >> want to commit to. Simon> I don't understand this part. Which tables/columns? My approach is based on reusing ui-out stuff, the idea being to associate a color with the ui-out table (or tuple or list) name and the field name. I suppose this wouldn't actually work for value printing, since that doesn't use ui-out. So maybe some other design is needed; or maybe value printing needs to be changed a bit. Tom