Mingw GDB build fails for M16C target

Mingw GDB build fails for M16C target

[Mahesh Basavaraj Shavari]

Hi,
I am trying to build a Mingw GDB for M16CM32C target using the
following source:
gdb-6.8.50.20090327
 
During make, I get the following error.
------------------------------------------------------------------------
-----------
mv version.c-tmp version.c
i386-pc-mingw32msvc-gcc -c -DHAVE_CONFIG_H     -DPROFILE=1
-DWITH_PROFILE=-1          -DDEFAULT_INLINE=0           -Wall -DTIMER_A
-D__USE_MINGW_FSEEK  -I.
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c -I../common
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/../common
-I../../include
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/../../include
-I../../bfd
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/../../bfd
-I../../opcodes
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/../../opcodes
-I../../intl -g -O2 -D__USE_MINGW_ACCESS version.c
i386-pc-mingw32msvc-gcc -c -DHAVE_CONFIG_H     -DPROFILE=1
-DWITH_PROFILE=-1          -DDEFAULT_INLINE=0           -Wall -DTIMER_A
-D__USE_MINGW_FSEEK  -I.
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c -I../common
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/../common
-I../../include
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/../../include
-I../../bfd
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/../../bfd
-I../../opcodes
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/../../opcodes
-I../../intl -g -O2 -D__USE_MINGW_ACCESS
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/gdb-if.c
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/gdb-if.c: In
function `m32c_signal_to_host':
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/gdb-if.c:541:
error: `SIGTRAP' undeclared (first use in this function)
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/gdb-if.c:541:
error: (Each undeclared identifier is reported only once
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/gdb-if.c:541:
error: for each function it appears in.)
make[3]: *** [gdb-if.o] Error 1
make[3]: Leaving directory
`/home/mahesh/GDB/gdb-6.8/build/m32c-elfbld6.8.50.20080811/sim/m32c'
make[2]: *** [all] Error 1
make[2]: Leaving directory
`/home/mahesh/GDB/gdb-6.8/build/m32c-elfbld6.8.50.20080811/sim'
make[1]: *** [all-sim] Error 2
make[1]: Leaving directory
`/home/mahesh/GDB/gdb-6.8/build/m32c-elfbld6.8.50.20080811'
make: *** [all] Error 2
------------------------------------------------------------------------
-----------
 
M16C target GNU Linux toolchain was built using the following sources.
Gcc-4.3.3
Binutils-2.19
Newlib-1.16.0
 
The native mingw toolchain (i386-pc-mingw32msvc-gcc) for i386 was built 
using the following source.
Gcc version 3.4.5
 
 
Any help would be highly appreciated.
Thanking you in anticipation.
 
Regards,
Mahesh Shavari.
 
------------------------------------------------------------------------
-----------

Re: Mingw GDB build fails for M16C target

[Kevin Buettner]

[Note: Reply-to has been set to gdb-patches.]

On Sat, 25 Apr 2009 11:05:25 +0530
Mahesh Basavaraj Shavari <Mahesh.Shavari@kpitcummins.com> wrote:

> /home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20080811/sim/m32c/gdb-if.c:541:
> error: `SIGTRAP' undeclared (first use in this function)

Mahesh,

Please try the patch below and let me know if it works for you.

Jim,

It appears to me that comment, "Oddly, the gdb/sim interface uses host
signal numbers...", isn't true.  My patch deletes this comment in
addition to using TARGET_SIGNAL_foo instead of SIGfoo.  If you look at
remote-sim.c, you'll see that `enum target_signal' (which defines the
various TARGET_SIGNAL_foo constants) is used throughout the file.

Okay to apply?

Kevin

	* m32c/gdb-if.c (m32c_signal_to_host): Rename to
	m32c_signal_to_target.  Change signal return values from SIGILL,
	SIGTRAP, SIGSEGV, etc. to TARGET_SIGNAL_ILL, TARGET_SIGNAL_TRAP,
	TARGET_SIGNAL_SEGV, etc.  Fix all callers.

Index: m32c/gdb-if.c
===================================================================
RCS file: /cvs/src/src/sim/m32c/gdb-if.c,v
retrieving revision 1.7
diff -u -p -r1.7 gdb-if.c
--- m32c/gdb-if.c	14 Jan 2009 10:53:07 -0000	1.7
+++ m32c/gdb-if.c	28 Apr 2009 22:38:44 -0000
@@ -523,52 +523,35 @@ int siggnal;
 
 
 /* Given a signal number used by the M32C bsp (that is, newlib),
-   return a host signal number.  (Oddly, the gdb/sim interface uses
-   host signal numbers...)  */
+   return a target signal number used by GDB.  */
 int
-m32c_signal_to_host (int m32c)
+m32c_signal_to_target (int m32c)
 {
   switch (m32c)
     {
     case 4:
-#ifdef SIGILL
-      return SIGILL;
-#else
-      return SIGSEGV;
-#endif
+      return TARGET_SIGNAL_ILL;
 
     case 5:
-      return SIGTRAP;
+      return TARGET_SIGNAL_TRAP;
 
     case 10:
-#ifdef SIGBUS
-      return SIGBUS;
-#else
-      return SIGSEGV;
-#endif
+      return TARGET_SIGNAL_BUS;
 
     case 11:
-      return SIGSEGV;
+      return TARGET_SIGNAL_SEGV;
 
     case 24:
-#ifdef SIGXCPU
-      return SIGXCPU;
-#else
-      break;
-#endif
+      return TARGET_SIGNAL_XCPU;
 
     case 2:
-      return SIGINT;
+      return TARGET_SIGNAL_INT;
 
     case 8:
-#ifdef SIGFPE
-      return SIGFPE;
-#else
-      break;
-#endif
+      return TARGET_SIGNAL_FPE;
 
     case 6:
-      return SIGABRT;
+      return TARGET_SIGNAL_ABRT;
     }
 
   return 0;
@@ -588,7 +571,7 @@ handle_step (int rc)
   else if (M32C_STOPPED (rc))
     {
       reason = sim_stopped;
-      siggnal = m32c_signal_to_host (M32C_STOP_SIG (rc));
+      siggnal = m32c_signal_to_target (M32C_STOP_SIG (rc));
     }
   else
     {

Re: Mingw GDB build fails for M16C target

[DJ Delorie]

> There is still following issue with simulator building:

Fixed.

2009-08-14  DJ Delorie  <dj@redhat.com>

	* configure.in: Check for sys/select.h, termios.h, sys/socket.h,
	netinet/in.h, and netinet/tcp.h.
	* configure: Regenerate.
	* config.in: Add those headers.
	* main.c: Check for them.
	(setup_tcp_console): Disable if no networking.
	(main): Note missing networking or termios.
	* mem.c: Check for those headers.
	(stdin_ready): Disable if no termios.
	(m32c_sim_restore_console): Disable if no termios.
	(mem_get_byte): Disable console input if no termios.
	
Index: config.in
===================================================================
RCS file: /cvs/src/src/sim/m32c/config.in,v
retrieving revision 1.2
diff -p -U3 -r1.2 config.in
--- config.in	11 Jul 2008 02:37:08 -0000	1.2
+++ config.in	14 Aug 2009 04:23:06 -0000
@@ -22,6 +22,12 @@
 /* Define to 1 if you have the <inttypes.h> header file. */
 #undef HAVE_INTTYPES_H
 
+/* Define to 1 if you have the <netinet/in.h> header file. */
+#undef HAVE_NETINET_IN_H
+
+/* Define to 1 if you have the <netinet/tcp.h> header file. */
+#undef HAVE_NETINET_TCP_H
+
 /* Define to 1 if you have the `nsl' library (-lnsl). */
 #undef HAVE_LIBNSL
 
@@ -49,15 +55,24 @@
 /* Define to 1 if you have the <sys/resource.h> header file. */
 #undef HAVE_SYS_RESOURCE_H
 
+/* Define to 1 if you have the <sys/select.h> header file. */
+#undef HAVE_SYS_SELECT_H
+
 /* Define to 1 if you have the <sys/stat.h> header file. */
 #undef HAVE_SYS_STAT_H
 
+/* Define to 1 if you have the <sys/socket.h> header file. */
+#undef HAVE_SYS_SOCKET_H
+
 /* Define to 1 if you have the <sys/time.h> header file. */
 #undef HAVE_SYS_TIME_H
 
 /* Define to 1 if you have the <sys/types.h> header file. */
 #undef HAVE_SYS_TYPES_H
 
+/* Define to 1 if you have the <termios.h> header file. */
+#undef HAVE_TERMIOS_H
+
 /* Define to 1 if you have the `time' function. */
 #undef HAVE_TIME
 
Index: configure.in
===================================================================
RCS file: /cvs/src/src/sim/m32c/configure.in,v
retrieving revision 1.5
diff -p -U3 -r1.5 configure.in
--- configure.in	14 Jan 2009 10:53:07 -0000	1.5
+++ configure.in	14 Aug 2009 04:23:06 -0000
@@ -28,4 +28,6 @@ sinclude(../common/aclocal.m4)
 # it by inlining the macro's contents.
 sinclude(../common/common.m4)
 
+AC_CHECK_HEADERS(sys/select.h termios.h sys/socket.h netinet/in.h netinet/tcp.h)
+
 SIM_AC_OUTPUT
Index: main.c
===================================================================
RCS file: /cvs/src/src/sim/m32c/main.c,v
retrieving revision 1.7
diff -p -U3 -r1.7 main.c
--- main.c	14 Jan 2009 10:53:07 -0000	1.7
+++ main.c	14 Aug 2009 04:23:06 -0000
@@ -19,6 +19,7 @@ You should have received a copy of the G
 along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 
+#include "config.h"
 #include <stdio.h>
 #include <string.h>
 #include <stdlib.h>
@@ -26,11 +27,21 @@ along with this program.  If not, see <h
 #include <assert.h>
 #include <setjmp.h>
 #include <signal.h>
-
 #include <sys/types.h>
+
+#ifdef HAVE_SYS_SOCKET_H
+#ifdef HAVE_NETINET_IN_H
+#ifdef HAVE_NETINET_TCP_H
+#define HAVE_networking
+#endif
+#endif
+#endif
+
+#ifdef HAVE_networking
 #include <sys/socket.h>
 #include <netinet/in.h>
 #include <netinet/tcp.h>
+#endif
 
 
 #include "bfd.h"
@@ -45,8 +56,10 @@ along with this program.  If not, see <h
 #include "timer_a.h"
 #endif
 
+#ifdef HAVE_networking
 extern int m32c_console_ofd;
 extern int m32c_console_ifd;
+#endif
 
 int m32c_disassemble = 0;
 static unsigned int cycles = 0;
@@ -63,6 +76,7 @@ done (int exit_code)
   exit (exit_code);
 }
 
+#ifdef HAVE_networking
 static void
 setup_tcp_console (char *portname)
 {
@@ -109,6 +123,7 @@ setup_tcp_console (char *portname)
   printf ("connection from %d.%d.%d.%d\n", a[0], a[1], a[2], a[3]);
   m32c_console_ofd = m32c_console_ifd;
 }
+#endif
 
 int
 main (int argc, char **argv)
@@ -116,7 +131,9 @@ main (int argc, char **argv)
   int o;
   int save_trace;
   bfd *prog;
+#ifdef HAVE_networking
   char *console_port_s = 0;
+#endif
 
   setbuf (stdout, 0);
 
@@ -129,10 +146,18 @@ main (int argc, char **argv)
 	trace++;
 	break;
       case 'c':
+#ifdef HAVE_networking
 	console_port_s = optarg;
+#else
+	fprintf (stderr, "Nework console not available in this build.\n");
+#endif
 	break;
       case 'C':
+#ifdef HAVE_TERMIOS_H
 	m32c_use_raw_console = 1;
+#else
+	fprintf (stderr, "Raw console not available in this build.\n");
+#endif
 	break;
       case 'v':
 	verbose++;
@@ -177,8 +202,10 @@ main (int argc, char **argv)
   m32c_load (prog);
   trace = save_trace;
 
+#ifdef HAVE_networking
   if (console_port_s)
     setup_tcp_console (console_port_s);
+#endif
 
   sim_disasm_init (prog);
 
Index: mem.c
===================================================================
RCS file: /cvs/src/src/sim/m32c/mem.c,v
retrieving revision 1.9
diff -p -U3 -r1.9 mem.c
--- mem.c	14 Jan 2009 10:53:07 -0000	1.9
+++ mem.c	14 Aug 2009 04:23:07 -0000
@@ -19,6 +19,7 @@ You should have received a copy of the G
 along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 
+#include "config.h"
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -26,8 +27,12 @@ along with this program.  If not, see <h
 #include <sys/time.h>
 #include <sys/types.h>
 #include <unistd.h>
+#ifdef HAVE_SYS_SELECT_H
 #include <sys/select.h>
+#endif
+#ifdef HAVE_TERMIOS_H
 #include <termios.h>
+#endif
 
 #include "mem.h"
 #include "cpu.h"
@@ -48,9 +53,13 @@ along with this program.  If not, see <h
 
 static unsigned char **pt[L1_LEN];
 
+#ifdef HAVE_TERMIOS_H
 int m32c_console_ifd = 0;
+#endif
 int m32c_console_ofd = 1;
+#ifdef HAVE_TERMIOS_H
 int m32c_use_raw_console = 0;
+#endif
 
 #ifdef TIMER_A
 Timer_A timer_a;
@@ -374,6 +383,7 @@ mem_get_pc ()
   return *m;
 }
 
+#ifdef HAVE_TERMIOS_H
 static int console_raw = 0;
 static struct termios oattr;
 
@@ -399,6 +409,7 @@ m32c_sim_restore_console ()
     tcsetattr (m32c_console_ifd, TCSANOW, &oattr);
   console_raw = 0;
 }
+#endif
 
 static unsigned char
 mem_get_byte (int address)
@@ -408,6 +419,7 @@ mem_get_byte (int address)
   m = mem_ptr (address);
   switch (address)
     {
+#ifdef HAVE_TERMIOS_H
     case 0x2ed:		/* m32c uart1c1 */
     case 0x3ad:		/* m16c uart1c1 */
 
@@ -447,6 +459,7 @@ mem_get_byte (int address)
 	  }
 	return c;
       }
+#endif
 
 #ifdef TIMER_A
     case 0x346:		/* TA0low */
@@ -457,6 +470,9 @@ mem_get_byte (int address)
       return timer_a.count;
 #endif
 
+    default:
+      /* In case both cases above are not included.  */
+      ;
     }
 
   S ("=>");

Re: Mingw GDB build fails for M16C target

[Mahesh Basavaraj Shavari]

Hi,

I have now built the MinGW gdb successfully but without simulator;
using option '--disable-sim'.

There is still following issue with simulator building:

>/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:29:24:
>sys/select.h: No such file or directory
>/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:30:21:
>termios.h: No such file or directory
>/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c: In function
>`stdin_ready':
>/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:383: error:
>`fd_set' undeclared (first use in this function)

Any help would be highly appreciated.
Thank you.

Best regards,
Mahesh Shavari

Re: Mingw GDB build fails for M16C target

[Mahesh Basavaraj Shavari]

> Mahesh,

> Please try the patch below and let me know if it works for you.

Hi Kevin,

Thanks for you help.
The provided patch solves the issues mentioned earlier, but gives the
following new errors.

------------------------------------------------------------------------
--------------------------

i386-pc-mingw32msvc-gcc -c -DHAVE_CONFIG_H     -DPROFILE=1
-DWITH_PROFILE=-1          -DDEFAULT_INLINE=0           -Wall -DTIMER_A
-D__USE_MINGW_FSEEK  -I.
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c -I../common
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/../common
-I../../include
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/../../include
-I../../bfd
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/../../bfd
-I../../opcodes
-I/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/../../opcodes
-I../../intl -g -O2 -D__USE_MINGW_ACCESS
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c

/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:29:24:
sys/select.h: No such file or directory
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:30:21:
termios.h: No such file or directory
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c: In function
`stdin_ready':
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:383: error:
`fd_set' undeclared (first use in this function)
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:383: error:
(Each undeclared identifier is reported only once
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:383: error:
for each function it appears in.)
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:383: error:
syntax error before "ifd"
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:389:
warning: implicit declaration of function `FD_ZERO'
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:389: error:
`ifd' undeclared (first use in this function)
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:390:
warning: implicit declaration of function `FD_SET'
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:391:
warning: implicit declaration of function `select'
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c: In function
`m32c_sim_restore_console':
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:399:
warning: implicit declaration of function `tcsetattr'
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:399: error:
`TCSANOW' undeclared (first use in this function)
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c: In function
`mem_get_byte':
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:416: error:
storage size of 'attr' isn't known
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:417:
warning: implicit declaration of function `tcgetattr'
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:420: error:
`ICANON' undeclared (first use in this function)
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:420: error:
`ECHO' undeclared (first use in this function)
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:420: error:
`ECHOE' undeclared (first use in this function)
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:421: error:
`TCSANOW' undeclared (first use in this function)
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:416:
warning: unused variable `attr'
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c: At top
level:
/home/mahesh/GDB/gdb-6.8/gdb-6.8.50.20090327/sim/m32c/mem.c:378: error:
storage size of `oattr' isn't known
make[3]: *** [mem.o] Error 1
make[3]: Leaving directory
`/home/mahesh/GDB/gdb-6.8/build/m32c-elfbld6.8.50.20090327/sim/m32c'
make[2]: *** [all] Error 1
make[2]: Leaving directory
`/home/mahesh/GDB/gdb-6.8/build/m32c-elfbld6.8.50.20090327/sim'
make[1]: *** [all-sim] Error 2
make[1]: Leaving directory
`/home/mahesh/GDB/gdb-6.8/build/m32c-elfbld6.8.50.20090327'
make: *** [all] Error 2

------------------------------------------------------------------------
-------------------

Thanking you in anticipation.
 
Regards,
Mahesh Shavari.