From: "Petr Hluzín" <petr.hluzin@gmail.com>
To: Tristan Gingold <gingold@adacore.com>,
Eric Weddington <Eric.Weddington@atmel.com>
Cc: gdb@sourceware.org
Subject: Re: a review and questions on avr_scan_prologue()
Date: Sat, 20 Feb 2010 23:20:00 -0000 [thread overview]
Message-ID: <6a6f635a1002201520k177588b3wa6fd927d492a633@mail.gmail.com> (raw)
In-Reply-To: <919F238C-4ED8-4507-8510-E5479E94B32D@adacore.com>
Hi
On 17 February 2010 10:02, Tristan Gingold <gingold@adacore.com> wrote:
>> else if (insn == 0x920f) /* push r0 */
>> {
>> info->size += 1;
>> vpc += 2;
>> }
>>
>> The condition is never true because of the preceding "Scan pushes
>> (saved registers)" loop's exit condition.
>
> I don't think so. You can have:
> rcall .+0
> push r0
You are right. (I have not realized that such case would be useful for
something.)
(Since you already committed the changes I am not filling the bug reports
Eric Weddington requested.)
--
Petr Hluzin
prev parent reply other threads:[~2010-02-20 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 23:56 Petr Hluzín
2010-02-16 5:13 ` Weddington, Eric
2010-02-17 9:02 ` Tristan Gingold
2010-02-20 23:20 ` Petr Hluzín [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a6f635a1002201520k177588b3wa6fd927d492a633@mail.gmail.com \
--to=petr.hluzin@gmail.com \
--cc=Eric.Weddington@atmel.com \
--cc=gdb@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox