From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25504 invoked by alias); 20 Feb 2010 23:20:55 -0000 Received: (qmail 25494 invoked by uid 22791); 20 Feb 2010 23:20:55 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ey-out-1920.google.com (HELO ey-out-1920.google.com) (74.125.78.145) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Feb 2010 23:20:51 +0000 Received: by ey-out-1920.google.com with SMTP id 4so296454eyg.42 for ; Sat, 20 Feb 2010 15:20:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.213.109.76 with SMTP id i12mr7228170ebp.2.1266708049131; Sat, 20 Feb 2010 15:20:49 -0800 (PST) In-Reply-To: <919F238C-4ED8-4507-8510-E5479E94B32D@adacore.com> References: <6a6f635a1002131556sc428adfu6033489930eca7b6@mail.gmail.com> <919F238C-4ED8-4507-8510-E5479E94B32D@adacore.com> From: =?UTF-8?B?UGV0ciBIbHV6w61u?= Date: Sat, 20 Feb 2010 23:20:00 -0000 Message-ID: <6a6f635a1002201520k177588b3wa6fd927d492a633@mail.gmail.com> Subject: Re: a review and questions on avr_scan_prologue() To: Tristan Gingold , Eric Weddington Cc: gdb@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00150.txt.bz2 Hi On 17 February 2010 10:02, Tristan Gingold wrote: >> =C2=A0 =C2=A0 =C2=A0else if (insn =3D=3D 0x920f) =C2=A0/* push r0 */ >> =C2=A0 =C2=A0 =C2=A0 =C2=A0{ >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0info->size +=3D 1; >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vpc +=3D 2; >> =C2=A0 =C2=A0 =C2=A0 =C2=A0} >> >> The condition is never true because of the preceding "Scan pushes >> (saved registers)" loop's exit condition. > > I don't think so. =C2=A0You can have: > =C2=A0rcall .+0 > =C2=A0push r0 You are right. (I have not realized that such case would be useful for something.) (Since you already committed the changes I am not filling the bug reports Eric Weddington requested.) --=20 Petr Hluzin