-nowindows (-nw) option cancels MI interpreter

-nowindows (-nw) option cancels MI interpreter

[Marc Khouzam]

Hi,

the -nowindows option to GDB caused the interpreter to be forced to be CONSOLE.
This means that something like
	gdb -i=mi -nw 
is equivalent to 
	gdb -i=console -nw

I would expect that the MI interpreter would not be affected by the -nw option...

It is also confusing (although a quick workaround)
that, because of the order options are read does matters
	gdb -nw -i=mi
will work.

From what I gather, there are two GUI interpreters: Insight and TUI.
Is that correct?

I was thinking that the -nw option should force the console
interpreter only if the current interpreter is one of the two GUI ones.

This problem is not of great impact, but it did cause me to waste
some time figuring out why DSF was suddently broken (once I added the -nw)

The patch below explains.
It does not fix the fact that:
	gdb -nw -i=tui
and
	gdb -i=tui -nw
don't behave the same (same for insight).


diff -u -r1.67 main.c
--- gdb/main.c  14 Mar 2008 17:21:07 -0000      1.67
+++ gdb/main.c  9 Apr 2008 16:47:19 -0000
@@ -160,6 +160,7 @@
   char *homedir;
 
   int i;
+  size_t len;
 
   long time_at_startup = get_run_time ();
 
@@ -410,9 +411,25 @@
            use_windows = 1;
            break;
          case OPT_NOWINDOWS:
-           /* -nw is equivalent to -i=console.  */
-           xfree (interpreter_p);
-           interpreter_p = xstrdup (INTERP_CONSOLE);
+           /* -nw is equivalent to -i=console, but only replace the
+              interpreter in the case it was a GUI interpreter.  */
+           len = sizeof(interpreter_p) < sizeof(INTERP_INSIGHT) ? 
+                 sizeof(interpreter_p) : sizeof(INTERP_INSIGHT);
+           if (memcmp (interpreter_p, INTERP_INSIGHT, len) == 0)
+             {
+               xfree (interpreter_p);
+               interpreter_p = xstrdup (INTERP_CONSOLE);
+             }
+           else
+             {
+               len = sizeof(interpreter_p) < sizeof(INTERP_TUI) ? 
+                   sizeof(interpreter_p) : sizeof(INTERP_TUI);
+               if (memcmp (interpreter_p, INTERP_TUI, len) == 0)
+                 {
+                   xfree (interpreter_p);
+                   interpreter_p = xstrdup (INTERP_CONSOLE);
+                 }
+             }
            use_windows = 0;
            break;
          case 'f':
== 
Marc Khouzam

Re: -nowindows (-nw) option cancels MI interpreter

[Daniel Jacobowitz]

On Wed, Apr 09, 2008 at 01:24:29PM -0400, Marc Khouzam wrote:
> Hi,
> 
> the -nowindows option to GDB caused the interpreter to be forced to be CONSOLE.
> This means that something like
> 	gdb -i=mi -nw 
> is equivalent to 
> 	gdb -i=console -nw
> 
> I would expect that the MI interpreter would not be affected by the -nw option...

-nw is completely equivalent to -i=console.  So it's sensitive to
where you put it on the command line.  I think it's easier to improve
the manual...

-- 
Daniel Jacobowitz
CodeSourcery

Re: -nowindows (-nw) option cancels MI interpreter

[Bob Rossi]

On Wed, Apr 09, 2008 at 01:35:39PM -0400, Daniel Jacobowitz wrote:
> On Wed, Apr 09, 2008 at 01:24:29PM -0400, Marc Khouzam wrote:
> > Hi,
> > 
> > the -nowindows option to GDB caused the interpreter to be forced to be CONSOLE.
> > This means that something like
> > 	gdb -i=mi -nw 
> > is equivalent to 
> > 	gdb -i=console -nw
> > 
> > I would expect that the MI interpreter would not be affected by the -nw option...
> 
> -nw is completely equivalent to -i=console.  So it's sensitive to
> where you put it on the command line.  I think it's easier to improve
> the manual...

Really? At one point, the cygwin build would automatically pop up
insight if you run gdb. So, I do -nw -a2 to start gdb. When I switch to
mi mode in the future, what should I put?

Bob Rossi

Re: -nowindows (-nw) option cancels MI interpreter

[Daniel Jacobowitz]

On Wed, Apr 09, 2008 at 01:40:35PM -0400, Bob Rossi wrote:
> Really? At one point, the cygwin build would automatically pop up
> insight if you run gdb. So, I do -nw -a2 to start gdb. When I switch to
> mi mode in the future, what should I put?

Just -i=mi (or -i=mi<number>).

-- 
Daniel Jacobowitz
CodeSourcery

Re: -nowindows (-nw) option cancels MI interpreter

[Michael Snyder]

On Wed, 2008-04-09 at 13:35 -0400, Daniel Jacobowitz wrote:
> On Wed, Apr 09, 2008 at 01:24:29PM -0400, Marc Khouzam wrote:
> > Hi,
> > 
> > the -nowindows option to GDB caused the interpreter to be forced to be CONSOLE.
> > This means that something like
> > 	gdb -i=mi -nw 
> > is equivalent to 
> > 	gdb -i=console -nw
> > 
> > I would expect that the MI interpreter would not be affected by the -nw option...
> 
> -nw is completely equivalent to -i=console.  So it's sensitive to
> where you put it on the command line.  I think it's easier to improve
> the manual...

I suppose, back in the day, we thought of MI as loosely
equivalent to "windowing interface".  But there could be
present or future MI clients that aren't windowing interfaces.

Maybe calls for a re-think.