Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: "Bin Chen" <binary.chen@gmail.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: gdb@sourceware.org, drow@false.org
Subject: Re: (len % 1) != 0
Date: Sun, 17 Feb 2008 14:41:00 -0000	[thread overview]
Message-ID: <5800c1cc0802170641g68ab2e5fte724cd076412333@mail.gmail.com> (raw)
In-Reply-To: <E1JQkG0-0005DD-0k@fencepost.gnu.org>

Hi Daniel,

Is it a bug?

On Sun, Feb 17, 2008 at 10:12 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Sun, 17 Feb 2008 13:57:31 +0800
>  > From: "Bin Chen" <binary.chen@gmail.com>
>
>
> >
>  > Hello,
>  >
>  > In gdb/gdbserver/server.c,
>  >
>  > there is a line:
>  >
>  > if ((len % 1) != 0 || unhexify (mon, own_buf + 6, len / 2) != len / 2)
>  >
>  > I am curious that (len % 1) != 0 is always false, why put here?
>
>  It's probably a bug: they meant len % 2.
>


  reply	other threads:[~2008-02-17 14:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17  5:57 Bin Chen
2008-02-17 14:13 ` Eli Zaretskii
2008-02-17 14:41   ` Bin Chen [this message]
2008-02-17 15:26     ` Daniel Jacobowitz
2008-02-19 16:32       ` Sheng-Liang Song
2008-02-19 18:25         ` Dave Korn
2008-02-19 18:30           ` David Daney
     [not found]           ` <18363.7810.91075.314867@gargle.gargle.HOWL>
2008-02-19 18:35             ` Dave Korn
2008-02-19 18:47               ` David Daney
2008-02-19 18:49                 ` Daniel Jacobowitz
2008-02-19 19:08                 ` Dave Korn
2008-02-19 21:41           ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5800c1cc0802170641g68ab2e5fte724cd076412333@mail.gmail.com \
    --to=binary.chen@gmail.com \
    --cc=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox