From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24225 invoked by alias); 17 Feb 2008 14:41:57 -0000 Received: (qmail 24217 invoked by uid 22791); 17 Feb 2008 14:41:57 -0000 X-Spam-Check-By: sourceware.org Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.159) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 17 Feb 2008 14:41:39 +0000 Received: by fg-out-1718.google.com with SMTP id e12so1090234fga.0 for ; Sun, 17 Feb 2008 06:41:37 -0800 (PST) Received: by 10.86.51.2 with SMTP id y2mr4854399fgy.50.1203259296776; Sun, 17 Feb 2008 06:41:36 -0800 (PST) Received: by 10.86.60.12 with HTTP; Sun, 17 Feb 2008 06:41:36 -0800 (PST) Message-ID: <5800c1cc0802170641g68ab2e5fte724cd076412333@mail.gmail.com> Date: Sun, 17 Feb 2008 14:41:00 -0000 From: "Bin Chen" To: "Eli Zaretskii" Subject: Re: (len % 1) != 0 Cc: gdb@sourceware.org, drow@false.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <5800c1cc0802162157g3ac31acas4ae95585b9b2e263@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00116.txt.bz2 Hi Daniel, Is it a bug? On Sun, Feb 17, 2008 at 10:12 PM, Eli Zaretskii wrote: > > Date: Sun, 17 Feb 2008 13:57:31 +0800 > > From: "Bin Chen" > > > > > > Hello, > > > > In gdb/gdbserver/server.c, > > > > there is a line: > > > > if ((len % 1) != 0 || unhexify (mon, own_buf + 6, len / 2) != len / 2) > > > > I am curious that (len % 1) != 0 is always false, why put here? > > It's probably a bug: they meant len % 2. >