From: John Breitenbach <breiten@lexmark.com>
To: gdb@sourceware.org
Subject: Re: gdb won't single-step over ARM integer divide opcode
Date: Mon, 10 Aug 2015 14:58:00 -0000 [thread overview]
Message-ID: <55C8BC0E.8060907@lpdev.prtdev.lexmark.com> (raw)
In-Reply-To: <55C73BEA.2050203@gmail.com>
Yao,
Yes, your patch does work for me. Sorry for not noticing your patch
earlier.
John
On 08/09/2015 07:39 AM, Yao Qi wrote:
> On 05/08/15 19:02, John Breitenbach wrote:
>> I did some debugging and have found that the function,
>> arm_get_next_pc_raw, inappropriately decodes this opcode as a load into
>> the PC register. (bits 24..27 are 7, bit 20 is set, and the dest
>> register appears to be the PC.
>>
>> Binutils's logic to disassemble the sdiv/udiv opcodes has opcode &
>> 0x0ff0f0f0 = 0x0710f010 (with bit 21 distinguishing between udiv and
>> sdiv)
>>
>> I've come up with the following patch which makes my situation work. But
>> I don't know how complete it is, as there may be other newer opcodes
>> which fall into the formerly undefined instruction space.
>
> Hi John,
> Thanks for your patch, however, I think I've fixed this problem in
> patch https://sourceware.org/ml/gdb-patches/2015-06/msg00610.html
> Does it work for you? This commit will be in 7.10 release.
>
>>
>> Also, the comment "byte write to PC" around line 4930 seems wrong, as
>> the check for bit 22 a few lines earlier catches that situation, and
>> what's left is word writes to the PC."
>>
>
> Yeah, it is possible. Patch is welcome :)
>
prev parent reply other threads:[~2015-08-10 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 18:03 John Breitenbach
2015-08-09 11:39 ` Yao Qi
2015-08-10 14:58 ` John Breitenbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C8BC0E.8060907@lpdev.prtdev.lexmark.com \
--to=breiten@lexmark.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox