From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb@sourceware.org
Subject: Re: Inadvertently run inferior threads
Date: Mon, 15 Jun 2015 15:28:00 -0000 [thread overview]
Message-ID: <557EEF0E.1040400@redhat.com> (raw)
In-Reply-To: <83vbepngxm.fsf@gnu.org>
On 06/15/2015 04:13 PM, Eli Zaretskii wrote:
>> Date: Mon, 15 Jun 2015 14:01:25 +0100
>> From: Pedro Alves <palves@redhat.com>
>> CC: gdb@sourceware.org
>>
>>> if (!tp->control.in_infcall)
>>> set_running (user_visible_resume_ptid (user_step), 1);
>>>
>>> it winds up calling 'set_running', because the in_infcall flag is set
>>> on the thread that called the inferior function, not on the thread
>>> which was started and triggered TARGET_WAITKIND_SPURIOUS.
>>>
>>> So 'set_running' is called, and it is called with minus_one_ptid,
>>> which then has the effect of marking all the threads as running.
>>
>> So that should mean that even for GNU/Linux, it should be possible
>> to end in the exact same, when any thread other than the one that we
>> had started the infcall in reports an event that doesn't cause a stop.
>> E.g., a thread specific breakpoint, a "handle nostop" signal, etc.
>
> Does that involve minus_one_ptid on GNU/Linux as well? If not, that
> call will not mark all threads as running, will it?
It does. user_visible_resume_ptid returns the same irrespective
of target_can_async.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-06-15 15:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 17:11 Eli Zaretskii
2015-03-14 13:40 ` Pedro Alves
2015-03-14 14:56 ` Eli Zaretskii
2015-03-14 15:36 ` Pedro Alves
2015-03-14 15:51 ` Pedro Alves
2015-03-14 15:58 ` Pedro Alves
2015-06-10 15:15 ` Eli Zaretskii
2015-03-14 16:06 ` Eli Zaretskii
2015-06-10 15:50 ` Eli Zaretskii
2015-06-11 13:42 ` Eli Zaretskii
2015-06-15 13:18 ` Pedro Alves
2015-06-15 15:27 ` Eli Zaretskii
2015-06-15 15:42 ` Pedro Alves
2015-06-23 4:07 ` Doug Evans
2015-06-23 12:19 ` Pedro Alves
2015-06-23 19:11 ` Pedro Alves
2015-06-23 19:52 ` Eli Zaretskii
2015-06-24 14:29 ` Eli Zaretskii
2015-06-29 15:57 ` Pedro Alves
2015-06-23 14:58 ` Eli Zaretskii
2015-06-15 13:01 ` Pedro Alves
2015-06-15 15:14 ` Eli Zaretskii
2015-06-15 15:28 ` Pedro Alves [this message]
2015-06-15 17:21 ` Eli Zaretskii
2015-06-15 17:56 ` Pedro Alves
2015-06-15 19:07 ` Eli Zaretskii
2015-06-23 11:51 ` Pedro Alves
2015-03-14 16:04 ` Eli Zaretskii
2015-03-14 16:15 ` Pedro Alves
2015-03-14 16:17 ` Eli Zaretskii
2015-03-14 16:23 ` Pedro Alves
2015-03-14 17:01 ` Eli Zaretskii
2015-03-14 17:46 ` Pedro Alves
2015-06-10 15:13 ` Eli Zaretskii
2015-06-15 13:08 ` Pedro Alves
2015-06-15 15:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557EEF0E.1040400@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox