Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Max Filippov <jcmvbkbc@gmail.com>, gdb@sourceware.org
Cc: Maxim Grigoriev <maxim2405@gmail.com>,
	Woody LaRue <larue@cadence.com>,
	       Marc Gauthier <marc@cadence.com>,
	linux-xtensa@linux-xtensa.org,
	       Daniel Jacobowitz <drow@false.org>
Subject: Re: [PATCH 2/2] gdbserver/xtensa: fix typo in XCHAL_HAVE_LOOPS
Date: Fri, 17 Apr 2015 11:29:00 -0000	[thread overview]
Message-ID: <5530EEA3.2040809@redhat.com> (raw)
In-Reply-To: <1429233286-6240-3-git-send-email-jcmvbkbc@gmail.com>

On 04/17/2015 02:14 AM, Max Filippov wrote:
> This fixes lbeg/lend/lcount registers handling through gdbserver.
> 
> 2015-04-17  Max Filippov  <jcmvbkbc@gmail.com>
> gdb/gdbserver/
> 	* linux-xtensa-low.c (xtensa_fill_gregset,
> 	xtensa_store_gregset): fix typo in XCHAL_HAVE_LOOPS

I was curious on whether it might have been that XCHAL_HAVE_LOOP
used to exist and was later renamed ("as in, how did this ever work
then?"), but googling around, it doesn't seem have ever existed
indeed.

Write instead:

2015-04-17  Max Filippov  <jcmvbkbc@gmail.com>
gdb/gdbserver/
	* linux-xtensa-low.c (xtensa_fill_gregset)
	(xtensa_store_gregset): Check XCHAL_HAVE_LOOPS instead
        of XCHAL_HAVE_LOOP.

OK with that change.

Thanks,
Pedro Alves


  reply	other threads:[~2015-04-17 11:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17  1:15 [PATCH 0/2] Fixes for xtensa gdbserver Max Filippov
2015-04-17  1:15 ` [PATCH 1/2] gdbserver/xtensa: drop xtensa_usrregs_info Max Filippov
2015-04-17 11:29   ` Pedro Alves
2015-04-17  1:15 ` [PATCH 2/2] gdbserver/xtensa: fix typo in XCHAL_HAVE_LOOPS Max Filippov
2015-04-17 11:29   ` Pedro Alves [this message]
2015-04-17 12:50     ` Max Filippov
2015-04-17 14:12       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5530EEA3.2040809@redhat.com \
    --to=palves@redhat.com \
    --cc=drow@false.org \
    --cc=gdb@sourceware.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=larue@cadence.com \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=marc@cadence.com \
    --cc=maxim2405@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox