Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: gdb@sourceware.org
Cc: Maxim Grigoriev <maxim2405@gmail.com>,
	Woody LaRue <larue@cadence.com>,	Marc Gauthier <marc@cadence.com>,
	linux-xtensa@linux-xtensa.org,	Daniel Jacobowitz <drow@false.org>,
	Pedro Alves <palves@redhat.com>,
	Max Filippov <jcmvbkbc@gmail.com>
Subject: [PATCH 1/2] gdbserver/xtensa: drop xtensa_usrregs_info
Date: Fri, 17 Apr 2015 01:15:00 -0000	[thread overview]
Message-ID: <1429233286-6240-2-git-send-email-jcmvbkbc@gmail.com> (raw)
In-Reply-To: <1429233286-6240-1-git-send-email-jcmvbkbc@gmail.com>

xtensa_usrregs_info refers to undefined variables xtensa_num_regs and
xtensa_regmap. Drop xtensa_usrregs_info and replace pointer to usrregs
in regs_info with NULL since all registers are read/set through regsets.

2015-04-17  Max Filippov  <jcmvbkbc@gmail.com>
gdb/gdbserver/
	* linux-xtensa-low.c (xtensa_usrregs_info): remove.
	(regs_info): replace usrregs pointer with NULL.
---
 gdb/gdbserver/linux-xtensa-low.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/gdb/gdbserver/linux-xtensa-low.c b/gdb/gdbserver/linux-xtensa-low.c
index f7fafaf..e786da5 100644
--- a/gdb/gdbserver/linux-xtensa-low.c
+++ b/gdb/gdbserver/linux-xtensa-low.c
@@ -186,16 +186,10 @@ static struct regsets_info xtensa_regsets_info =
     NULL, /* disabled_regsets */
   };
 
-static struct usrregs_info xtensa_usrregs_info =
-  {
-    xtensa_num_regs,
-    xtensa_regmap,
-  };
-
 static struct regs_info regs_info =
   {
     NULL, /* regset_bitmap */
-    &xtensa_usrregs_info,
+    NULL, /* usrregs */
     &xtensa_regsets_info
   };
 
-- 
1.8.1.4


  parent reply	other threads:[~2015-04-17  1:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17  1:15 [PATCH 0/2] Fixes for xtensa gdbserver Max Filippov
2015-04-17  1:15 ` [PATCH 2/2] gdbserver/xtensa: fix typo in XCHAL_HAVE_LOOPS Max Filippov
2015-04-17 11:29   ` Pedro Alves
2015-04-17 12:50     ` Max Filippov
2015-04-17 14:12       ` Pedro Alves
2015-04-17  1:15 ` Max Filippov [this message]
2015-04-17 11:29   ` [PATCH 1/2] gdbserver/xtensa: drop xtensa_usrregs_info Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429233286-6240-2-git-send-email-jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=drow@false.org \
    --cc=gdb@sourceware.org \
    --cc=larue@cadence.com \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=marc@cadence.com \
    --cc=maxim2405@gmail.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox