Re: many unused function warnings in gdb 7.9 on darwin

[Pedro Alves <palves@redhat.com>]

On 02/24/2015 04:33 PM, Jack Howarth wrote:
>    Building the gdb 7.9 release on x86_64-apple-darwin14 produces many
> warnings of the form...
> 
> remote.c:2567:1: warning: unused function
> 'VEC_thread_item_t_embedded_size' [-Wunused-function]
> DEF_VEC_O(thread_item_t);
> ^
> ./common/vec.h:435:20: note: expanded from macro 'DEF_VEC_O'
> VEC_T(T);                                                                 \
>                                                                           ^
> ./common/vec.h:863:22: note: expanded from macro '\
> DEF_VEC_FUNC_O'
> static inline size_t VEC_OP (T,embedded_size)                             \
>                      ^
> ./common/vec.h:399:22: note: expanded from macro 'VEC_OP'
> #define VEC_OP(T,OP) VEC_##T##_##OP
>                      ^
> <scratch space>:55:1: note: expanded from here
> VEC_thread_item_t_embedded_size
> ^
> 
> Shouldn't those VEC declarations use a wrapper to avoid them on
> targets not supporting that code?

AFAIK, -Wunused-function is supposed to be suppressed for
"static inline" functions:

 -Wunused-function
     Warn whenever a static function is declared but not defined
     or a non-inline static function is unused. This warning is
     enabled by -Wall.

Looks like a clang bug here?

(I suspect marking the function with attribute used would
work around this.)

Thanks,
Pedro Alves