From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-44144-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 57567 invoked by alias); 26 Feb 2015 10:18:01 -0000
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
Received: (qmail 57558 invoked by uid 89); 26 Feb 2015 10:18:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Feb 2015 10:18:00 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1QAHvnv021829	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Thu, 26 Feb 2015 05:17:57 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1QAHu2X027982;	Thu, 26 Feb 2015 05:17:56 -0500
Message-ID: <54EEF2D4.2000602@redhat.com>
Date: Thu, 26 Feb 2015 16:48:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Jack Howarth <howarth.mailing.lists@gmail.com>, gdb@sourceware.org
Subject: Re: many unused function warnings in gdb 7.9 on darwin
References: <CADtEn-0a2XqyNySrYL-OrC=yYvBs_uuVFNnJE5KdHt_-7FHsaA@mail.gmail.com>
In-Reply-To: <CADtEn-0a2XqyNySrYL-OrC=yYvBs_uuVFNnJE5KdHt_-7FHsaA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-02/txt/msg00066.txt.bz2

On 02/24/2015 04:33 PM, Jack Howarth wrote:
>    Building the gdb 7.9 release on x86_64-apple-darwin14 produces many
> warnings of the form...
> 
> remote.c:2567:1: warning: unused function
> 'VEC_thread_item_t_embedded_size' [-Wunused-function]
> DEF_VEC_O(thread_item_t);
> ^
> ./common/vec.h:435:20: note: expanded from macro 'DEF_VEC_O'
> VEC_T(T);                                                                 \
>                                                                           ^
> ./common/vec.h:863:22: note: expanded from macro '\
> DEF_VEC_FUNC_O'
> static inline size_t VEC_OP (T,embedded_size)                             \
>                      ^
> ./common/vec.h:399:22: note: expanded from macro 'VEC_OP'
> #define VEC_OP(T,OP) VEC_##T##_##OP
>                      ^
> <scratch space>:55:1: note: expanded from here
> VEC_thread_item_t_embedded_size
> ^
> 
> Shouldn't those VEC declarations use a wrapper to avoid them on
> targets not supporting that code?

AFAIK, -Wunused-function is supposed to be suppressed for
"static inline" functions:

 -Wunused-function
     Warn whenever a static function is declared but not defined
     or a non-inline static function is unused. This warning is
     enabled by -Wall.

Looks like a clang bug here?

(I suspect marking the function with attribute used would
work around this.)

Thanks,
Pedro Alves