From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, brobecker@adacore.com, gbenson@redhat.com,
stanshebs@earthlink.net, gdb@sourceware.org
Subject: Re: Patchwork patch tracking system
Date: Wed, 21 May 2014 21:35:00 -0000 [thread overview]
Message-ID: <537D1C08.8000204@redhat.com> (raw)
In-Reply-To: <83wqdfm2l9.fsf@gnu.org>
On 05/21/2014 07:03 PM, Eli Zaretskii wrote:
>> Date: Wed, 21 May 2014 18:18:06 +0100
>> From: Pedro Alves <palves@redhat.com>
>> CC: Gary Benson <gbenson@redhat.com>, Stan Shebs <stanshebs@earthlink.net>, gdb@sourceware.org
>>
>> The fact that the ChangeLog is usually not a part of the patch
>> and then is added before push changes the hash.
>
> But that's just for historical reasons, right? If we use
> git-changelog-merge, there should be no reason not to make ChangeLog
> changes part of the patch, right?
Right, but still, but if that merge actually changes the patch,
because it puts the ChangeLog entry at the top of the file, and
the top commit is no longer the same as was when the patch was
generated for submission (frequently true), then the hash changes.
--
Pedro Alves
prev parent reply other threads:[~2014-05-21 21:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 10:08 Gary Benson
2014-04-04 22:50 ` Stan Shebs
2014-04-17 18:18 ` Gary Benson
2014-04-22 15:40 ` Joel Brobecker
2014-04-22 15:51 ` Eric Christopher
2014-04-22 18:37 ` Joel Brobecker
2014-04-24 11:42 ` Siva Chandra
2014-08-02 14:25 ` Mike Frysinger
2014-04-29 17:25 ` Tom Tromey
2014-04-29 17:36 ` Eli Zaretskii
2014-04-29 18:58 ` Joel Brobecker
2014-04-30 9:19 ` Gary Benson
2014-04-30 12:45 ` Joel Brobecker
2014-04-29 19:33 ` Pedro Alves
2014-04-29 22:32 ` Breazeal, Don
2014-04-30 1:08 ` Pedro Alves
2014-04-30 3:45 ` Breazeal, Don
2014-05-21 14:47 ` Tom Tromey
2014-05-21 17:18 ` Pedro Alves
2014-05-21 17:49 ` Joel Brobecker
2014-05-21 18:03 ` Eli Zaretskii
2014-05-21 18:23 ` Joel Brobecker
2014-05-21 18:48 ` Eli Zaretskii
2014-05-21 19:45 ` Joel Brobecker
2014-05-21 21:35 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537D1C08.8000204@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gbenson@redhat.com \
--cc=gdb@sourceware.org \
--cc=stanshebs@earthlink.net \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox