From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27476 invoked by alias); 21 May 2014 21:35:18 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 27463 invoked by uid 89); 21 May 2014 21:35:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 May 2014 21:35:14 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LLZ78Q019842 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 May 2014 17:35:07 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4LLZ4Jt024959; Wed, 21 May 2014 17:35:05 -0400 Message-ID: <537D1C08.8000204@redhat.com> Date: Wed, 21 May 2014 21:35:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Eli Zaretskii CC: tromey@redhat.com, brobecker@adacore.com, gbenson@redhat.com, stanshebs@earthlink.net, gdb@sourceware.org Subject: Re: Patchwork patch tracking system References: <20140402100842.GA956@blade.nx> <533F3713.40700@earthlink.net> <20140417135040.GA891@blade.nx> <20140422130652.GG5790@adacore.com> <8738gw6p4b.fsf@fleche.redhat.com> <87tx8jnq7j.fsf@fleche.redhat.com> <537CDFCE.7000407@redhat.com> <83wqdfm2l9.fsf@gnu.org> In-Reply-To: <83wqdfm2l9.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00045.txt.bz2 On 05/21/2014 07:03 PM, Eli Zaretskii wrote: >> Date: Wed, 21 May 2014 18:18:06 +0100 >> From: Pedro Alves >> CC: Gary Benson , Stan Shebs , gdb@sourceware.org >> >> The fact that the ChangeLog is usually not a part of the patch >> and then is added before push changes the hash. > > But that's just for historical reasons, right? If we use > git-changelog-merge, there should be no reason not to make ChangeLog > changes part of the patch, right? Right, but still, but if that merge actually changes the patch, because it puts the ChangeLog entry at the top of the file, and the top commit is no longer the same as was when the patch was generated for submission (frequently true), then the hash changes. -- Pedro Alves