From: Luis Machado <lgustavo@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb@sourceware.org
Subject: Re: Assuming types for PC
Date: Mon, 10 Jun 2013 14:49:00 -0000 [thread overview]
Message-ID: <51B5E76A.5000208@codesourcery.com> (raw)
In-Reply-To: <20130610144520.GF3941@adacore.com>
On 06/10/2013 04:45 PM, Joel Brobecker wrote:
>> Architectures are free to deal with the types of their PC's as they
>> please. Some keep the standard while others don't. I don't have a
>> strong opinion here, but i wouldn't call this a bug immediately.
>>
>>>
>>>> If PC should not have a fixed type, i think it would be best to remove
>>>> this check.
>>>
>>> Please don't.
>>
>> Is there a more elaborate reasoning for not removing this check?
>
> Here is a URL to the original discussion. DanielJ mention that we might
> want to loosen up the check, but then added something that confirms
> Mark's preference:
>
> http://www.sourceware.org/ml/gdb-patches/2008-01/msg00699.html
> | Might want to loosen the expected type; I don't think every platform
> | returns a function type for PC.
> |
> | Then again, might not want to - everyone should do so :-)
>
> So, I'm guessing that without a compelling reason to change it,
> it should stay that way...
>
Right. I did some archaeology and ended up at that commit, aimed at
testing for an internal error fix rather than the correct type of PC.
I didn't find the reasoning particularly clear. Then again, i'm just
asking to be sure. :-)
next prev parent reply other threads:[~2013-06-10 14:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 14:19 Luis Machado
2013-06-10 14:31 ` Mark Kettenis
2013-06-10 14:34 ` Luis Machado
2013-06-10 14:45 ` Joel Brobecker
2013-06-10 14:49 ` Luis Machado [this message]
2013-06-10 14:56 ` Joel Brobecker
2013-06-10 15:04 ` Mark Kettenis
2013-06-10 15:18 ` Luis Machado
2013-06-10 18:04 ` Maciej W. Rozycki
2013-06-10 18:44 ` Mark Kettenis
2013-06-11 9:21 ` Pedro Alves
2013-06-11 10:09 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B5E76A.5000208@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox