From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18821 invoked by alias); 10 Jun 2013 14:49:35 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 18805 invoked by uid 89); 10 Jun 2013 14:49:33 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 10 Jun 2013 14:49:31 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Um3PV-0000FC-RB from Luis_Gustavo@mentor.com ; Mon, 10 Jun 2013 07:49:29 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 10 Jun 2013 07:49:29 -0700 Received: from [172.30.64.168] ([172.30.64.168]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 10 Jun 2013 07:49:29 -0700 Message-ID: <51B5E76A.5000208@codesourcery.com> Date: Mon, 10 Jun 2013 14:49:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Joel Brobecker CC: Mark Kettenis , gdb@sourceware.org Subject: Re: Assuming types for PC References: <51B5E06A.8020807@codesourcery.com> <201306101431.r5AEVAfb007850@glazunov.sibelius.xs4all.nl> <51B5E3D4.9010105@codesourcery.com> <20130610144520.GF3941@adacore.com> In-Reply-To: <20130610144520.GF3941@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00024.txt.bz2 On 06/10/2013 04:45 PM, Joel Brobecker wrote: >> Architectures are free to deal with the types of their PC's as they >> please. Some keep the standard while others don't. I don't have a >> strong opinion here, but i wouldn't call this a bug immediately. >> >>> >>>> If PC should not have a fixed type, i think it would be best to remove >>>> this check. >>> >>> Please don't. >> >> Is there a more elaborate reasoning for not removing this check? > > Here is a URL to the original discussion. DanielJ mention that we might > want to loosen up the check, but then added something that confirms > Mark's preference: > > http://www.sourceware.org/ml/gdb-patches/2008-01/msg00699.html > | Might want to loosen the expected type; I don't think every platform > | returns a function type for PC. > | > | Then again, might not want to - everyone should do so :-) > > So, I'm guessing that without a compelling reason to change it, > it should stay that way... > Right. I did some archaeology and ended up at that commit, aimed at testing for an internal error fix rather than the correct type of PC. I didn't find the reasoning particularly clear. Then again, i'm just asking to be sure. :-)