* Python detection fallout with non GNU sed
@ 2011-02-01 20:41 Andreas Tobler
2011-02-02 4:45 ` Joel Brobecker
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Tobler @ 2011-02-01 20:41 UTC (permalink / raw)
To: gdb
Hi all,
a recent commit to the configure.ac/configure in src/gdb broke the
machinery on machines which do not have GNU sed.
The issue is the following:
sed -e 's,^.* -l\(python[0-9]*[.]\?[0-9]*\).*$,\1,'`
On certain sed implementations the quantifier '\?' can not be used on
backreferences.
This breaks the detection of python.
Here it fails on darwin and FreeBSD.
I tried the follwoing on those systems and on linux-ppc:
sed -e 's,^.* -l\(python[0-9]*[.][0-9]*\).*$,\1,'`
(the same expression w/o the \? quantifier.)
So far I do not see a drawback. But maybe I did not cover all aspects.
I do not have a *win* system to test on.
What do you think?
Gruss,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Python detection fallout with non GNU sed
2011-02-01 20:41 Python detection fallout with non GNU sed Andreas Tobler
@ 2011-02-02 4:45 ` Joel Brobecker
2011-02-02 16:10 ` Andreas Tobler
0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2011-02-02 4:45 UTC (permalink / raw)
To: Andreas Tobler; +Cc: gdb
> a recent commit to the configure.ac/configure in src/gdb broke the
> machinery on machines which do not have GNU sed.
That's me, sorry.
> I tried the follwoing on those systems and on linux-ppc:
>
> sed -e 's,^.* -l\(python[0-9]*[.][0-9]*\).*$,\1,'`
>
> (the same expression w/o the \? quantifier.)
This is not going to work on Windows, because windows the python
library does not have the dot in the version number (Eg: Python27).
I've checked in a fix. Can you retry?
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Python detection fallout with non GNU sed
2011-02-02 4:45 ` Joel Brobecker
@ 2011-02-02 16:10 ` Andreas Tobler
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Tobler @ 2011-02-02 16:10 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb
On 02.02.11 05:45, Joel Brobecker wrote:
>> a recent commit to the configure.ac/configure in src/gdb broke the
>> machinery on machines which do not have GNU sed.
>
> That's me, sorry.
Np.
>> I tried the follwoing on those systems and on linux-ppc:
>>
>> sed -e 's,^.* -l\(python[0-9]*[.][0-9]*\).*$,\1,'`
>>
>> (the same expression w/o the \? quantifier.)
>
> This is not going to work on Windows, because windows the python
> library does not have the dot in the version number (Eg: Python27).
>
> I've checked in a fix. Can you retry?
This is fine with me. Tested on darwin and FreeBSD. Works perfect here.
Thank you very much for the quick fix.
Gruss,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-02 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-01 20:41 Python detection fallout with non GNU sed Andreas Tobler
2011-02-02 4:45 ` Joel Brobecker
2011-02-02 16:10 ` Andreas Tobler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox