From: michael <michael@evidence.eu.com>
To: "Courousse, Damien" <damien.courousse@logica.com>
Cc: gdb@sourceware.org
Subject: Re: gdbserver on sh4
Date: Fri, 19 Jun 2009 16:20:00 -0000 [thread overview]
Message-ID: <4A3BB9E1.1010604@evidence.eu.com> (raw)
In-Reply-To: <F81DF98CADE6064F81A746D7C832359367160A@fr-ex009.groupinfra.com>
Hi,
Courousse, Damien wrote:
>
>> -----Message d'origine-----
>> De : michael [mailto:michael@evidence.eu.com]
>> Envoyé : vendredi 19 juin 2009 18:02
>> Ã : Courousse, Damien
>> Cc : gdb@sourceware.org
>> Objet : Re: gdbserver on sh4
>>
>> damien.courousse.logica wrote:
>>
>>> Hello all,
>>>
>>>
>>> Hi,
>>>
>>> Paul Mundt wrote:
>>>
>>>
>>>> On Tue, Mar 31, 2009 at 11:02:38AM +0200, Michael Trimarchi wrote:
>>>>
>>>>
>>>>
>>>>> Paul Mundt wrote:
>>>>>
>>>>>
>>>>>
>>>>>> On Tue, Mar 31, 2009 at 10:23:18AM +0200, Michael Trimarchi wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> The problem is kernel side and not gdb side. I send a patch to the
>>>>>>> linux-sh mailing list. They save the dsp register on the stack
>>>>>>>
>> before
>>
>>>>>>> the processor cpu register but the offset of the struct is wrong
>>>>>>> calculated and if the linux kernel is compiled with the dsp option
>>>>>>> the PEEKUSR return the wrong register value.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> The sanest thing really is just to throw the DSP state in to the
>>>>>>
>> thread
>>
>>>>>> struct as we do with the FPU, and kill off all of the special DSP
>>>>>>
>> state
>>
>>>>>> handling we have today. It costs us a thread flag to do lazy context
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> I just send a patch that put the dsp state in the thread struct
>>>>>
>>>>>
>>>>>
>>>> You sent a patch that cached the enable/disable state in the thread
>>>> struct, not the register state. ;-)
>>>>
>>>>
>>>>
>>>>
>>>>>> switching, but it's worth it to get that crap out of the regular
>>>>>> register
>>>>>> save/restore paths, which is just way too fragile, and has not seen
>>>>>>
>> any
>>
>>>>>> real maintenance since SH3-DSP.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> So move the save/restore part of the dsp in private data of task and
>>>>>
>> do
>>
>>>>> like
>>>>> mips?
>>>>>
>>>>>
>>>>>
>>>> Yes.
>>>>
>>>>
>>>>
>>> Ok, I will try to provide a new patch to move out the dsp save/restore
>>> part from the
>>> stack and move all on the thread privata data.
>>>
>>>
>>>
>>> I am currently facing the same problem that is described in this thread,
>>> also on sh4.
>>> Michael did you provide a kernel patch to fix this? If possible, how
>>>
>> could I
>>
>>> help you?
>>>
>>>
>> Hi, I just move the dsp register over the stack and I try it. What
>> kernel version do you use?
>>
>> Michael
>>
> Hi Michael,
>
> I use a kernel source tree modified by STmicroelectronics : linux-sh4-STAPI_2.6.23.17_stm23_A16 - it is based on the kernel 2.6.23.
>
The manteiner has applied the patch to the current linux git. Now you
can try to apply to your
branch.
Michael
prev parent reply other threads:[~2009-06-19 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 11:23 michael
2009-03-14 7:58 ` michael
2009-03-31 5:46 ` binom
2009-03-31 8:26 ` Michael Trimarchi
2009-03-31 8:56 ` Paul Mundt
2009-03-31 9:05 ` Michael Trimarchi
2009-03-31 9:07 ` Paul Mundt
2009-03-31 9:11 ` Michael Trimarchi
2009-06-19 15:56 ` damien.courousse.logica
2009-06-19 16:05 ` michael
2009-06-19 16:14 ` damien.courousse.logica
[not found] ` <F81DF98CADE6064F81A746D7C832359367160A@fr-ex009.groupinfra.com>
2009-06-19 16:20 ` michael [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3BB9E1.1010604@evidence.eu.com \
--to=michael@evidence.eu.com \
--cc=damien.courousse@logica.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox