From: Stan Shebs <stanshebs@earthlink.net>
To: gdb@sourceware.org
Subject: Encouraging patch reviewers
Date: Sat, 28 Jun 2008 18:43:00 -0000 [thread overview]
Message-ID: <48668628.8050904@earthlink.net> (raw)
At the GCC summit we discussed patch review a bit, and one of the
thoughts was that people who are not official maintainers of anything
will often study a posted patch, and get a good idea of whether it's
desirable, needs fixes, etc, but then maybe don't say anything because
it won't be an "official" opinion. But it really does help to post such
reviews, and quite likely a maintainer will simply rubberstamp it,
saving time all around. So speaking up really helps, but in looking at
gdb/MAINTAINERS I don't see anything that explicitly encourages people
to post their own reviews - it just says "anyone [...] may suggest
changes or ask questions". Does anybody think we need stronger phrasing
here, and if so, how should it read?
Stan
next reply other threads:[~2008-06-28 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 18:43 Stan Shebs [this message]
2008-06-29 14:48 ` Daniel Jacobowitz
2008-06-29 15:05 ` Robert Dewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48668628.8050904@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox