From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8898 invoked by alias); 28 Jun 2008 18:43:47 -0000 Received: (qmail 8881 invoked by uid 22791); 28 Jun 2008 18:43:46 -0000 X-Spam-Check-By: sourceware.org Received: from elasmtp-masked.atl.sa.earthlink.net (HELO elasmtp-masked.atl.sa.earthlink.net) (209.86.89.68) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 28 Jun 2008 18:42:51 +0000 Received: from [68.108.140.244] (helo=macbook-2.local) by elasmtp-masked.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1KCfNp-0007C3-5W for gdb@sourceware.org; Sat, 28 Jun 2008 14:42:49 -0400 Message-ID: <48668628.8050904@earthlink.net> Date: Sat, 28 Jun 2008 18:43:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) MIME-Version: 1.0 To: gdb@sourceware.org Subject: Encouraging patch reviewers Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da9403f94e80639b1e3a8d69cb49fdbb43219350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00304.txt.bz2 At the GCC summit we discussed patch review a bit, and one of the thoughts was that people who are not official maintainers of anything will often study a posted patch, and get a good idea of whether it's desirable, needs fixes, etc, but then maybe don't say anything because it won't be an "official" opinion. But it really does help to post such reviews, and quite likely a maintainer will simply rubberstamp it, saving time all around. So speaking up really helps, but in looking at gdb/MAINTAINERS I don't see anything that explicitly encourages people to post their own reviews - it just says "anyone [...] may suggest changes or ask questions". Does anybody think we need stronger phrasing here, and if so, how should it read? Stan