Re: Tensilica would like to submit an XTENSA GDB patch

Re: Tensilica would like to submit an XTENSA GDB patch

[Maxim Grigoriev]

Hi Daniel,

 > You've already been referred to the CONTRIBUTE file

Yes, I got it. So I'm going to follow this instruction.

 > One of the most important things when submitting a new port is to start
 > by submitting each fix to the generic (target-independent) portion of
 > GDB, with an explanation of why it is necessary. If you just post a
 > single large patch, no one will be interested in reviewing it.

Thanks much for the explanation. It helps to understand the process.

My first update doesn't include any target-independent code. In the 
future, I'd expect us to have some generic fixes for the problems 
exposed by XTENSA users. But, it doesn't seem to be an issue right now.

 > If you intend to continue maintaining it, then yes. If not we probably
 > would reject the contribution. It's of no use if no one is keeping it 
up to date.

Yes, we're highly interested in maintaining it.

Thanks,
Maxim

Daniel Jacobowitz wrote:
> On Mon, Jul 10, 2006 at 03:59:20PM -0700, Maxim Grigoriev wrote:
>  
>> Hi,
>>
>> My email addresses GDB maintainers.
>>
>> I merged GDB Tensilica local changes with GDB 6.5, and it works fine. 
>> We'd like to submit XTENSA port and start monitoring it. It would 
>> benefit both us and our customers. Once in while, Tensilica tried to 
>> submit an XTENSA port, but it didn't work out for some reason.
>>
>> So if this is possible can somebody among GDB maintainers start 
>> working with me, please ?
>>
>> I'll probably need a short instruction or a reference to the right 
>> document describing how to submit GDB patches.
>>     
>
> You've already been referred to the CONTRIBUTE file; it's fairly
> useful.  You can also find lots of examples in the mailing list
> archives for the gdb-patches mailing list.
>
> One of the most important things when submitting a new port is to start
> by submitting each fix to the generic (target-independent) portion of
> GDB, with an explanation of why it is necessary.  If you just post a
> single large patch, no one will be interested in reviewing it.
>
> We're always short of maintainer time, but we do the best we can
> to see that patches get looked at.
>
>  
>> And, question: If I succeed with submitting XTENSA port, should I 
>> become a maintainer for the XTENSA-specific code ?
>>     
>
> If you intend to continue maintaining it, then yes.  If not we probably
> would reject the contribution.  It's of no use if no one is keeping it
> up to date.
>
>   

Tensilica would like to submit an XTENSA GDB patch

[Maxim Grigoriev]

Hi,

My email addresses GDB maintainers.

I merged GDB Tensilica local changes with GDB 6.5, and it works fine. 
We'd like to submit XTENSA port and start monitoring it. It would 
benefit both us and our customers. Once in while, Tensilica tried to 
submit an XTENSA port, but it didn't work out for some reason.

So if this is possible can somebody among GDB maintainers start working 
with me, please ?

I'll probably need a short instruction or a reference to the right 
document describing how to submit GDB patches.

And, question: If I succeed with submitting XTENSA port, should I become 
a maintainer for the XTENSA-specific code ?

Thanks in advance for any of your help,

Maxim Grigoriev
Tensilica, Inc.
3255-6 Scott Boulevard
Santa Clara, CA 95054-3013
(w) 408-566-1770

Re: Tensilica would like to submit an XTENSA GDB patch

[Robert Dewar]

Maxim Grigoriev wrote:
> Hi,
> 
> My email addresses GDB maintainers.
> 
> I merged GDB Tensilica local changes with GDB 6.5, and it works fine. 
> We'd like to submit XTENSA port and start monitoring it. It would 
> benefit both us and our customers. Once in while, Tensilica tried to 
> submit an XTENSA port, but it didn't work out for some reason.
> 
> So if this is possible can somebody among GDB maintainers start working 
> with me, please ?
> 
> I'll probably need a short instruction or a reference to the right 
> document describing how to submit GDB patches.

Step one, file a proper copyright assignment form. Copies of this form
may be obtained from the Free Software Foundation (they are not 
available on line).

Re: Tensilica would like to submit an XTENSA GDB patch

[Nick Roberts]

 > > I'll probably need a short instruction or a reference to the right 
 > > document describing how to submit GDB patches.
 > 
 > Step one, file a proper copyright assignment form. Copies of this form
 > may be obtained from the Free Software Foundation (they are not 
 > available on line).

Step two read the CONTRIBUTE file?

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: Tensilica would like to submit an XTENSA GDB patch

[Petr Vandrovec]

Robert Dewar wrote:
> Maxim Grigoriev wrote:
> 
>> I'll probably need a short instruction or a reference to the right 
>> document describing how to submit GDB patches.
> 
> 
> Step one, file a proper copyright assignment form. Copies of this form
> may be obtained from the Free Software Foundation (they are not 
> available on line).

Well, I'm confused.  FSF website tells me 
(http://www.fsf.org/licensing/assigning.html) that I should contact maintainer 
to obtain copyright assignment forms.  What is proper address to ask for the 
forms, if not gdb@sourceware.org ?  gdb-patches?  Or should I email maintainers 
mentioned at http://directory.fsf.org/gdb.html individually ?

I have patches to fix PR 2142 & 735 from gnats (preliminary diffs are available 
in gnats, if you are curious - big blob with them is at 
http://platan.vc.cvut.cz/gdb.diff) - are these patches OK without copyright 
assignment, or should I fill copyright assignment, and if I should fill 
copyright assignment, then whom should I contact to get forms ?
					Thanks,
						Petr Vandrovec

Re: Tensilica would like to submit an XTENSA GDB patch

[Daniel Jacobowitz]

On Tue, Jul 11, 2006 at 02:02:31AM +0200, Petr Vandrovec wrote:
> Robert Dewar wrote:
> >Step one, file a proper copyright assignment form. Copies of this form
> >may be obtained from the Free Software Foundation (they are not 
> >available on line).
> 
> Well, I'm confused.  FSF website tells me 
> (http://www.fsf.org/licensing/assigning.html) that I should contact 
> maintainer to obtain copyright assignment forms.  What is proper address to 
> ask for the forms, if not gdb@sourceware.org ?

This list is fine.  The maintainers of GDB can send you the appropriate
request form - you just need to ask for it.  I'll send it to you in a
moment.  Then you get the actual paperwork from the FSF.

For company assignments it tends to be a bit more complicated, and we
often need to refer contributors to the FSF.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Tensilica would like to submit an XTENSA GDB patch

[Maxim Grigoriev]

Robert, Nick, thanks much for your replies,
>> My email addresses GDB maintainers.
>>
>> I merged GDB Tensilica local changes with GDB 6.5, and it works fine. 
>> We'd like to submit XTENSA port and start monitoring it. It would 
>> benefit both us and our customers. Once in while, Tensilica tried to 
>> submit an XTENSA port, but it didn't work out for some reason.
>>
>> So if this is possible can somebody among GDB maintainers start 
>> working with me, please ?
>>
>> I'll probably need a short instruction or a reference to the right 
>> document describing how to submit GDB patches.
>
> Step one, file a proper copyright assignment form. Copies of this form
> may be obtained from the Free Software Foundation (they are not 
> available on line).
I think it's already done.

Please, let me know if I need to refile it ( the previous one was sent 
some time ago ).

-- Maxim

Re: Tensilica would like to submit an XTENSA GDB patch

[Daniel Jacobowitz]

On Mon, Jul 10, 2006 at 05:05:41PM -0700, Maxim Grigoriev wrote:
> Please, let me know if I need to refile it ( the previous one was sent 
> some time ago ).

It looks fine to me.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Tensilica would like to submit an XTENSA GDB patch

[Daniel Jacobowitz]

On Mon, Jul 10, 2006 at 03:59:20PM -0700, Maxim Grigoriev wrote:
> Hi,
> 
> My email addresses GDB maintainers.
> 
> I merged GDB Tensilica local changes with GDB 6.5, and it works fine. 
> We'd like to submit XTENSA port and start monitoring it. It would 
> benefit both us and our customers. Once in while, Tensilica tried to 
> submit an XTENSA port, but it didn't work out for some reason.
> 
> So if this is possible can somebody among GDB maintainers start working 
> with me, please ?
> 
> I'll probably need a short instruction or a reference to the right 
> document describing how to submit GDB patches.

You've already been referred to the CONTRIBUTE file; it's fairly
useful.  You can also find lots of examples in the mailing list
archives for the gdb-patches mailing list.

One of the most important things when submitting a new port is to start
by submitting each fix to the generic (target-independent) portion of
GDB, with an explanation of why it is necessary.  If you just post a
single large patch, no one will be interested in reviewing it.

We're always short of maintainer time, but we do the best we can
to see that patches get looked at.

> And, question: If I succeed with submitting XTENSA port, should I become 
> a maintainer for the XTENSA-specific code ?

If you intend to continue maintaining it, then yes.  If not we probably
would reject the contribution.  It's of no use if no one is keeping it
up to date.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Tensilica would like to submit an XTENSA GDB patch

[Maxim Grigoriev]

Hi Daniel,

 > You've already been referred to the CONTRIBUTE file

Yes, I got it. So I'm going to follow this instruction.

 > One of the most important things when submitting a new port is to start
 > by submitting each fix to the generic (target-independent) portion of
 > GDB, with an explanation of why it is necessary. If you just post a
 > single large patch, no one will be interested in reviewing it.

Thanks much for the explanation, it helps to understand the process.

My first update doesn't include any target-independent code. In the 
future, I'd expect us to have some generic fixes for the problems 
exposed by XTENSA users. But, it doesn't seem to be an issue right now.

 > If you intend to continue maintaining it, then yes. If not we probably
 > would reject the contribution. It's of no use if no one is keeping it 
up to date.

Yes, we're highly interested in maintaining it.

Thanks,
Maxim

Daniel Jacobowitz wrote:
> On Mon, Jul 10, 2006 at 03:59:20PM -0700, Maxim Grigoriev wrote:
>  
>> Hi,
>>
>> My email addresses GDB maintainers.
>>
>> I merged GDB Tensilica local changes with GDB 6.5, and it works fine. 
>> We'd like to submit XTENSA port and start monitoring it. It would 
>> benefit both us and our customers. Once in while, Tensilica tried to 
>> submit an XTENSA port, but it didn't work out for some reason.
>>
>> So if this is possible can somebody among GDB maintainers start 
>> working with me, please ?
>>
>> I'll probably need a short instruction or a reference to the right 
>> document describing how to submit GDB patches.
>>     
>
> You've already been referred to the CONTRIBUTE file; it's fairly
> useful.  You can also find lots of examples in the mailing list
> archives for the gdb-patches mailing list.
>
> One of the most important things when submitting a new port is to start
> by submitting each fix to the generic (target-independent) portion of
> GDB, with an explanation of why it is necessary.  If you just post a
> single large patch, no one will be interested in reviewing it.
>
> We're always short of maintainer time, but we do the best we can
> to see that patches get looked at.
>
>  
>> And, question: If I succeed with submitting XTENSA port, should I 
>> become a maintainer for the XTENSA-specific code ?
>>     
>
> If you intend to continue maintaining it, then yes.  If not we probably
> would reject the contribution.  It's of no use if no one is keeping it
> up to date.
>
>