Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Michael Chastain <mec.gnu@mindspring.com>
To: manjo@austin.ibm.com, drow@false.org
Cc: gdb@sources.redhat.com
Subject: Re: [RFC] GDB testsuite patch.
Date: Wed, 25 Aug 2004 13:48:00 -0000	[thread overview]
Message-ID: <412C98BD.nail10P1YTPHK@mindspring.com> (raw)
In-Reply-To: <20040825124945.GA25217@nevyn.them.org>

Daniel Jacobowitz <drow@false.org> wrote:
> That's not the same as what you've done.  gdb_file_cmd should not
> always fail for objects without debugging information, since there are
> other tests that work OK without it.  This only applies to the gdb.gdb/
> tests.

Damn, I noticed this, but I got so caught up in the procedural criticism,
I forgot to mention it.

Daniel is right; gdb_file_cmd is not a good place to test for this
unconditionally.  You have to look in gdb.gdb/*.exp and find a good
way so that you make this check only for gdb.gdb/*.exp.

Michael


  reply	other threads:[~2004-08-25 13:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-19 18:10 gdb.gdb/ testcase issues Manoj Iyer
2004-08-19 21:23 ` Michael Chastain
2004-08-19 22:16   ` Manoj Iyer
2004-08-20  8:51     ` Michael Chastain
2004-08-25  5:03       ` [RFC] GDB testsuite patch Manoj Iyer
2004-08-25 12:49         ` Daniel Jacobowitz
2004-08-25 13:48           ` Michael Chastain [this message]
2004-08-25 13:44         ` Michael Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=412C98BD.nail10P1YTPHK@mindspring.com \
    --to=mec.gnu@mindspring.com \
    --cc=drow@false.org \
    --cc=gdb@sources.redhat.com \
    --cc=manjo@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox