From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20724 invoked by alias); 25 Aug 2004 13:48:49 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 20717 invoked from network); 25 Aug 2004 13:48:48 -0000 Received: from unknown (HELO hall.mail.mindspring.net) (207.69.200.60) by sourceware.org with SMTP; 25 Aug 2004 13:48:48 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by hall.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1Bzy8l-0005WM-00; Wed, 25 Aug 2004 09:48:39 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 4913E4B102; Wed, 25 Aug 2004 09:48:45 -0400 (EDT) Date: Wed, 25 Aug 2004 13:48:00 -0000 From: Michael Chastain To: manjo@austin.ibm.com, drow@false.org Subject: Re: [RFC] GDB testsuite patch. Cc: gdb@sources.redhat.com Message-ID: <412C98BD.nail10P1YTPHK@mindspring.com> References: <41251A45.nail58D215HD7@mindspring.com> <4125BB8B.nailJWP1FZGHJ@mindspring.com> <20040825124945.GA25217@nevyn.them.org> In-Reply-To: <20040825124945.GA25217@nevyn.them.org> User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00368.txt.bz2 Daniel Jacobowitz wrote: > That's not the same as what you've done. gdb_file_cmd should not > always fail for objects without debugging information, since there are > other tests that work OK without it. This only applies to the gdb.gdb/ > tests. Damn, I noticed this, but I got so caught up in the procedural criticism, I forgot to mention it. Daniel is right; gdb_file_cmd is not a good place to test for this unconditionally. You have to look in gdb.gdb/*.exp and find a good way so that you make this check only for gdb.gdb/*.exp. Michael