Re: Coding style

[Andrew Cagney <ac131313@redhat.com>]

> (most notably Andrew :-)

It depends on the day of the week.  Sometimes my new code contains lots 
of blank lines, sometimes it doesn't.

Btw, the blank line here:

int
max_register_size (struct gdbarch *gdbarch)
{
   struct regcache_descr *descr;

   descr = regcache_descr (gdbarch);
   return descr->max_register_size;
}

makes sense, but when contracted into:

> int
> max_register_size (struct gdbarch *gdbarch)
> {
>   struct regcache_descr *descr = regcache_descr (gdbarch);
> 
>   return descr->max_register_size;
> }

or:

> int
> max_register_size (struct gdbarch *gdbarch)
> {
>   struct regcache_descr *descr = regcache_descr (gdbarch);
>   return descr->max_register_size;
> }

things get pretty arbitrary.  Is "descr" a declaration or code body?

Anyway, if your new code adds blank lines, I can't remove them without 
rewritting the function - the requirement to keep white space changes 
separate from fixes stops this.

Andrew

PS: This is somewhat ironic, Stan was oft to complain that my code 
contained too many blank lines :-)