From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-13635-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 15300 invoked by alias); 2 May 2003 18:46:30 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 15293 invoked from network); 2 May 2003 18:46:29 -0000
Received: from unknown (HELO localhost.redhat.com) (207.219.125.105)
  by sources.redhat.com with SMTP; 2 May 2003 18:46:29 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 4ECB52B2F; Fri,  2 May 2003 14:46:27 -0400 (EDT)
Message-ID: <3EB2BD03.8070407@redhat.com>
Date: Fri, 02 May 2003 18:46:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb@sources.redhat.com
Subject: Re: Coding style
References: <200305021010.h42AAgOQ030687@elgar.kettenis.dyndns.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-05/txt/msg00018.txt.bz2

> (most notably Andrew :-)

It depends on the day of the week.  Sometimes my new code contains lots 
of blank lines, sometimes it doesn't.

Btw, the blank line here:

int
max_register_size (struct gdbarch *gdbarch)
{
   struct regcache_descr *descr;

   descr = regcache_descr (gdbarch);
   return descr->max_register_size;
}

makes sense, but when contracted into:

> int
> max_register_size (struct gdbarch *gdbarch)
> {
>   struct regcache_descr *descr = regcache_descr (gdbarch);
> 
>   return descr->max_register_size;
> }

or:

> int
> max_register_size (struct gdbarch *gdbarch)
> {
>   struct regcache_descr *descr = regcache_descr (gdbarch);
>   return descr->max_register_size;
> }

things get pretty arbitrary.  Is "descr" a declaration or code body?

Anyway, if your new code adds blank lines, I can't remove them without 
rewritting the function - the requirement to keep white space changes 
separate from fixes stops this.

Andrew

PS: This is somewhat ironic, Stan was oft to complain that my code 
contained too many blank lines :-)