From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb@sources.redhat.com
Subject: Re: ARI `asection' and `sec_ptr'
Date: Mon, 24 Feb 2003 15:05:00 -0000 [thread overview]
Message-ID: <3E5A3550.7020700@redhat.com> (raw)
In-Reply-To: <20030224142459.GA24793@nevyn.them.org>
> On Mon, Feb 24, 2003 at 01:43:26AM -0500, Andrew Cagney wrote:
>
>> Hello,
>>
>> Assuming I'm reading the code right. BFD has the declarations:
>>
>> typedef struct sec
>> {
>> ...
>> } asection;
>> typedef struct sec *sec_ptr;
>>
>> GDB uses all three (sec_ptr, asection, struct sec) and that makes things
>> pretty confusing. Consequently, I've added asection and sec_ptr to the
>> ARI. Instead people can use `struct sec *' which is consistent with
>> GDB's other types.
>
>
> Must you? BFD makes a conscious effort to (almost always) use
> asection* in its interfaces. If you want to reduce bfd.h includes,
> solve this one in BFD too.
Que? Where, in the above did I mention #includes? As I pointed out,
GDB uses all three of these vis:
asection *foo;
sec_ptr foo;
struct sec *foo;
so unless the developer happens to know this relationship, they can miss
some vital relationships.
GDB's preference is `struct sec' however, yes, BFD may have other
preferences. You'll note that I've already sent out a patch to clarify
the status of `struct _bfd'.
Andrew
next prev parent reply other threads:[~2003-02-24 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-24 6:41 Andrew Cagney
2003-02-24 14:25 ` Daniel Jacobowitz
2003-02-24 15:05 ` Andrew Cagney [this message]
2003-02-24 15:18 ` Daniel Jacobowitz
2003-02-24 15:40 ` Andrew Cagney
2003-02-24 15:49 ` Daniel Jacobowitz
2003-02-24 16:18 ` Andrew Cagney
2003-02-24 16:20 ` Daniel Jacobowitz
2003-03-01 13:41 ` Mark Kettenis
2003-03-01 15:13 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E5A3550.7020700@redhat.com \
--to=ac131313@redhat.com \
--cc=drow@mvista.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox