From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5626 invoked by alias); 24 Feb 2003 15:05:45 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 5612 invoked from network); 24 Feb 2003 15:05:43 -0000 Received: from unknown (HELO localhost.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 24 Feb 2003 15:05:43 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 987E5294F; Mon, 24 Feb 2003 10:08:00 -0500 (EST) Message-ID: <3E5A3550.7020700@redhat.com> Date: Mon, 24 Feb 2003 15:05:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb@sources.redhat.com Subject: Re: ARI `asection' and `sec_ptr' References: <3E59BF0E.7020708@redhat.com> <20030224142459.GA24793@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00513.txt.bz2 > On Mon, Feb 24, 2003 at 01:43:26AM -0500, Andrew Cagney wrote: > >> Hello, >> >> Assuming I'm reading the code right. BFD has the declarations: >> >> typedef struct sec >> { >> ... >> } asection; >> typedef struct sec *sec_ptr; >> >> GDB uses all three (sec_ptr, asection, struct sec) and that makes things >> pretty confusing. Consequently, I've added asection and sec_ptr to the >> ARI. Instead people can use `struct sec *' which is consistent with >> GDB's other types. > > > Must you? BFD makes a conscious effort to (almost always) use > asection* in its interfaces. If you want to reduce bfd.h includes, > solve this one in BFD too. Que? Where, in the above did I mention #includes? As I pointed out, GDB uses all three of these vis: asection *foo; sec_ptr foo; struct sec *foo; so unless the developer happens to know this relationship, they can miss some vital relationships. GDB's preference is `struct sec' however, yes, BFD may have other preferences. You'll note that I've already sent out a patch to clarify the status of `struct _bfd'. Andrew