Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Richard.Earnshaw@arm.com
Cc: Kevin Buettner <kevinb@redhat.com>, gdb@sources.redhat.com
Subject: Re: [rfc] frame->frame => frame->addr && frame->base()
Date: Fri, 12 Apr 2002 07:05:00 -0000	[thread overview]
Message-ID: <3CB6E994.2010005@cygnus.com> (raw)
In-Reply-To: <200204121253.NAA03207@cam-mail2.cambridge.arm.com>

> Rather than worrying in detail about what should be held in the "frame" 
> structure, shouldn't we be more concerned with the methods that need to 
> access the frame?  Once we have that, what needs to be stored should 
> become obvious.
> 
> R.

I'm not too worried by the methods used to access a frame (once 
created).  I'm trying to focus in on just the frame creation phase.  In 
theory, the code should look like:

	create_frame (frame_addr, frame_pc /*I'm loosing that one :-)*/,
		frame_next);

The reality - get_prev_frame() - is unfortunatly, very very different. 
To appreciate ``the quality'' of the current situtation, grep for '->pc 
= ' and '->frame = ' in the tdep.c code, and look at how SP_REGNUM is 
special cased in frame->saved_regs[].

Still, I've had some success.  The code I've got is starting to look 
like the above while still keeping the existing code working - even has 
a cache :-)

enjoy,
Andrew


  reply	other threads:[~2002-04-12 14:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-11 13:56 Andrew Cagney
2002-04-11 15:29 ` Kevin Buettner
2002-04-11 16:42   ` Andrew Cagney
2002-04-12  5:54     ` Richard Earnshaw
2002-04-12  7:05       ` Andrew Cagney [this message]
2002-04-12  5:50 ` Richard Earnshaw
2002-04-12  6:38   ` Andrew Cagney
2002-04-12  8:53     ` Kevin Buettner
2002-04-12  9:05       ` Andrew Cagney
2002-04-12 14:59 ` Jim Blandy
2002-04-26  7:58 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CB6E994.2010005@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox