From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19696 invoked by alias); 12 Apr 2002 14:05:11 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 19684 invoked from network); 12 Apr 2002 14:05:10 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 12 Apr 2002 14:05:10 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4B08B3CD8; Fri, 12 Apr 2002 10:05:08 -0400 (EDT) Message-ID: <3CB6E994.2010005@cygnus.com> Date: Fri, 12 Apr 2002 07:05:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Richard.Earnshaw@arm.com Cc: Kevin Buettner , gdb@sources.redhat.com Subject: Re: [rfc] frame->frame => frame->addr && frame->base() References: <200204121253.NAA03207@cam-mail2.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00211.txt.bz2 > Rather than worrying in detail about what should be held in the "frame" > structure, shouldn't we be more concerned with the methods that need to > access the frame? Once we have that, what needs to be stored should > become obvious. > > R. I'm not too worried by the methods used to access a frame (once created). I'm trying to focus in on just the frame creation phase. In theory, the code should look like: create_frame (frame_addr, frame_pc /*I'm loosing that one :-)*/, frame_next); The reality - get_prev_frame() - is unfortunatly, very very different. To appreciate ``the quality'' of the current situtation, grep for '->pc = ' and '->frame = ' in the tdep.c code, and look at how SP_REGNUM is special cased in frame->saved_regs[]. Still, I've had some success. The code I've got is starting to look like the above while still keeping the existing code working - even has a cache :-) enjoy, Andrew