Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Doug Evans <dje@transmeta.com>
Cc: gdb@sources.redhat.com
Subject: Re: bitrot in buildsym.c:start_subfile
Date: Thu, 04 Apr 2002 05:51:00 -0000	[thread overview]
Message-ID: <3CAC5A6B.8090803@cygnus.com> (raw)
In-Reply-To: <200204040558.VAA14915@casey.transmeta.com>

> In buildsym.c there's this:
> 
> /* Start recording information about source code that came from an
>    included (or otherwise merged-in) source file with a different
>    name.  NAME is the name of the file (cannot be NULL), DIRNAME is
>    the directory in which it resides (or NULL if not known).  */
> 
> void
> start_subfile (char *name, char *dirname)
> {
> 
> 
> `name' cannot be NULL.
> 
> However, there's this:
> 
>   subfile->name = (name == NULL) ? NULL : savestring (name, strlen (name));
> 
> and this:
> 
>   if (subfile->name)
> 
> Am I missing something?

Doesn't look like it.  Guess the comment is wrong.  Any hints from the 
callers?

To figure out the full history will mean grubbing around in the old 
cygnus repository.  It might be easier to track that with a bug report.

enjoy,
Andrew



  reply	other threads:[~2002-04-04 13:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-03 21:58 Doug Evans
2002-04-04  5:51 ` Andrew Cagney [this message]
2002-04-04 10:08   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CAC5A6B.8090803@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=dje@transmeta.com \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox