From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32193 invoked by alias); 4 Apr 2002 13:51:45 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 32183 invoked from network); 4 Apr 2002 13:51:43 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 4 Apr 2002 13:51:43 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4BA453E59; Thu, 4 Apr 2002 08:51:39 -0500 (EST) Message-ID: <3CAC5A6B.8090803@cygnus.com> Date: Thu, 04 Apr 2002 05:51:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Doug Evans Cc: gdb@sources.redhat.com Subject: Re: bitrot in buildsym.c:start_subfile References: <200204040558.VAA14915@casey.transmeta.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00041.txt.bz2 > In buildsym.c there's this: > > /* Start recording information about source code that came from an > included (or otherwise merged-in) source file with a different > name. NAME is the name of the file (cannot be NULL), DIRNAME is > the directory in which it resides (or NULL if not known). */ > > void > start_subfile (char *name, char *dirname) > { > > > `name' cannot be NULL. > > However, there's this: > > subfile->name = (name == NULL) ? NULL : savestring (name, strlen (name)); > > and this: > > if (subfile->name) > > Am I missing something? Doesn't look like it. Guess the comment is wrong. Any hints from the callers? To figure out the full history will mean grubbing around in the old cygnus repository. It might be easier to track that with a bug report. enjoy, Andrew