Re: Results of a multi-build (not good)

[Andrew Cagney <ac131313@cygnus.com>]

> On Mon, 11 Mar 2002, Richard Earnshaw wrote:
> 
> 
>> that build successfully.  Not a surprise then to find that, with the 
>> exception of vax-dec-vms5.5, these are the only ports that don't use 
>> -Werror.
> 
> 
> IMHO, -Werror is a Bad Idea (tm).  With the current trend in GCC and 
> other compilers to print warnings for perfectly valid C, -Werror tends to 
> break good code with every new release of GCC, to say nothing of 
> development snapshots people use.
> 
> I think we should stop using -Werror, except maybe in maintainer's mode.

-Werror is only enabled when someone explicitly specifies it with 
--enable-gdb-warnings=,-Werror.

I don't think -Werror on its own is a problem.  Rather, I think things 
go wrong when it is combined with some options (-Wunused-param) or 
headers (solaris 1.5.1 was bad).  This is also why it isn't enabled by 
default and only a very select set of options are included.

BTW, I currently get only one (valid) failure when doing a build on 
{Free,Net}BSD.

enjoy,
Andrew