From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14938 invoked by alias); 12 Mar 2002 17:11:10 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 14870 invoked from network); 12 Mar 2002 17:11:08 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 12 Mar 2002 17:11:08 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 8CF3D3E9F; Tue, 12 Mar 2002 12:11:05 -0500 (EST) Message-ID: <3C8E36A9.1060304@cygnus.com> Date: Tue, 12 Mar 2002 09:11:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210 X-Accept-Language: en-us MIME-Version: 1.0 To: Eli Zaretskii Cc: Richard.Earnshaw@arm.com, gdb@sources.redhat.com Subject: Re: Results of a multi-build (not good) References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-03/txt/msg00106.txt.bz2 > On Mon, 11 Mar 2002, Richard Earnshaw wrote: > > >> that build successfully. Not a surprise then to find that, with the >> exception of vax-dec-vms5.5, these are the only ports that don't use >> -Werror. > > > IMHO, -Werror is a Bad Idea (tm). With the current trend in GCC and > other compilers to print warnings for perfectly valid C, -Werror tends to > break good code with every new release of GCC, to say nothing of > development snapshots people use. > > I think we should stop using -Werror, except maybe in maintainer's mode. -Werror is only enabled when someone explicitly specifies it with --enable-gdb-warnings=,-Werror. I don't think -Werror on its own is a problem. Rather, I think things go wrong when it is combined with some options (-Wunused-param) or headers (solaris 1.5.1 was bad). This is also why it isn't enabled by default and only a very select set of options are included. BTW, I currently get only one (valid) failure when doing a build on {Free,Net}BSD. enjoy, Andrew