* Fixing Linux/SPARC
@ 2001-10-17 7:08 Mark Kettenis
2001-11-07 7:12 ` Daniel Jacobowitz
0 siblings, 1 reply; 4+ messages in thread
From: Mark Kettenis @ 2001-10-17 7:08 UTC (permalink / raw)
To: gdb, drow
Hi Dan & other interested folks,
Something like the code below (completely untested, probably doesn't
even compile) is needed to fix Linux/SPARC.
Mark
/* Native-dependent code for Linux/SPARC.
Copyright 2001 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */
#include "defs.h"
#include "regcache.h"
#include <sys/procfs.h>
/* Prototypes for supply_gregset etc. */
#include "gregset.h"
void
supply_gregset (elf_gregset_t *gregsetp)
{
elf_greg_t *regp = (elf_greg_t *) gregsetp;
int i;
for (i = G0_REGNUM; i <= I7_REGNUM; i++)
supply_register (i, (char *) (regp + (i - G0_REGNUM)));
supply_register (PS_REGNUM, (char *) (regp + 32));
supply_register (PC_REGNUM, (char *) (regp + 33));
supply_register (NPC_REGNUM, (char *) (regp + 34));
supply_register (Y_REGNUM, (char *) (regp + 35));
supply_register (WIM_REGNUM, (char *) (regp + 36));
supply_register (TBR_REGNUM, (char *) (regp + 37));
/* Fill inaccessible registers with zero. */
supply_register (CPS_REGNUM, NULL);
}
void
fill_gregset (elf_gregset_t *gregsetp, int regno)
{
elf_greg_t *regp = (elf_greg_t *) gregsetp;
int i;
for (i = G0_REGNUM; i <= I7_REGNUM; i++)
if (regno == -1 || regno == i)
read_register_gen (i, (char *) (regp + (i - G0_REGNUM)));
if (regno == -1 || regno == PS_REGNUM)
read_register_gen (PS_REGNUM, (char *) (regp + 32));
if (regno == -1 || regno == PC_REGNUM)
read_register_gen (PC_REGNUM, (char *) (regp + 33));
if (regno == -1 || regno == NPC_REGNUM)
read_register_gen (NPC_REGNUM, (char *) (regp + 34));
if (regno == -1 || regno == Y_REGNUM)
read_register_gen (Y_REGNUM, (char *) (regp + 35));
if (regno == -1 || regno == WIM_REGNUM)
read_register_gen (WIM_REGNUM, (char *) (regp + 36));
if (regno == -1 || regno == TBR_REGNUM)
read_register_gen (TBR_REGNUM, (char *) (regp + 37));
}
void
supply_fpregset (elf_fpregset_t *fpregsetp)
{
int i;
for (i = FPO_REGNUM; i < FP0_REGNUM + 32; i++)
supply_register (i, (char *) &fpregsetp->pr_fr.pr_regs[i - FP0_REGNUM]);
supply_register (FPS_REGNUM, (char *) &fpregsetp->pr_fsr);
}
void
fill_fpregset (elf_fpregset_t *fpregsetp, int regno)
{
int i;
for (i = FP0_REGNUM; i < FP0_REGNUM + 32; i++)
if (regno == -1 || regno == i)
read_register_gen (i, (char *) &fregsetp->pr_fr.pr_regs[i - FP0_REGNUM]);
if (regno == -1 || regno == FPS_REGNUM)
read_register_gen (FPS_REGNUM, (char *) &fpregsetp->pr_fsr);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fixing Linux/SPARC
2001-10-17 7:08 Fixing Linux/SPARC Mark Kettenis
@ 2001-11-07 7:12 ` Daniel Jacobowitz
2001-11-07 9:22 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Jacobowitz @ 2001-11-07 7:12 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb
On Wed, Oct 17, 2001 at 04:07:52PM +0200, Mark Kettenis wrote:
> Hi Dan & other interested folks,
>
> Something like the code below (completely untested, probably doesn't
> even compile) is needed to fix Linux/SPARC.
Compiles, after fixing the obvious typos. I'm going to commit it to
the mainline as obvious, since it takes Linux/SPARC from not-building
to building; test results are abysmal, though. It looks as if we can't
figure out the memory location variables are stored at correctly.
They're being accessed in the unmapped 0x90000000 segment instead of
0x70000000, and not even at the right offsets. I'll look in to it more
later.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.1784
retrieving revision 1.1785
diff -u -p -r1.1784 -r1.1785
--- ChangeLog 2001/11/17 00:08:10 1.1784
+++ ChangeLog 2001/11/17 18:38:29 1.1785
@@ -1,3 +1,10 @@
+2001-11-17 Daniel Jacobowitz <drow@mvista.com>
+
+ * Makefile.in: Add mips-linux-nat.c, mips-linux-tdep.c,
+ and sparc-linux-nat.c to ALLDEPFILES. Add dependencies.
+ * config/sparc/linux.mh: Add sparc-linux-nat.o to NATDEPFILES.
+ * sparc-linux-nat.c: New file, from Mark Kettenis.
+
2001-11-16 Jakub Jelinek <jakub@redhat.com>
* dwarf2read.c (dwarf_str_buffer): New.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.128
retrieving revision 1.129
diff -u -p -r1.128 -r1.129
--- Makefile.in 2001/11/16 19:53:29 1.128
+++ Makefile.in 2001/11/17 18:38:29 1.129
@@ -1190,6 +1190,7 @@ ALLDEPFILES = 29k-share/udi/udip2soc.c 2
m68k-tdep.c \
m88k-nat.c m88k-tdep.c mac-nat.c \
mcore-tdep.c \
+ mips-linux-nat.c mips-linux-tdep.c \
mips-nat.c \
mips-tdep.c mipsm3-nat.c mipsv4-nat.c news-xdep.c \
nindy-share/Onindy.c nindy-share/nindy.c \
@@ -1206,7 +1207,8 @@ ALLDEPFILES = 29k-share/udi/udip2soc.c 2
rs6000-nat.c rs6000-tdep.c \
s390-tdep.c s390-nat.c \
ser-go32.c ser-pipe.c ser-tcp.c \
- sh-tdep.c solib.c solib-svr4.c solib-sunos.c sparc-nat.c \
+ sh-tdep.c solib.c solib-svr4.c solib-sunos.c sparc-linux-nat.c \
+ sparc-nat.c \
sparc-tdep.c sparcl-tdep.c sun3-nat.c \
symm-tdep.c symm-nat.c \
vax-tdep.c \
@@ -1721,6 +1723,11 @@ mem-break.o: mem-break.c $(defs_h)
minsyms.o: minsyms.c $(bfd_h) $(defs_h) $(objfiles_h) $(symfile_h) \
$(symtab_h) $(gdb_string_h) $(value_h) $(cp_abi_h)
+mips-linux-nat.o: mips-linux-nat.c $(defs_h)
+
+mips-linux-tdep.o: mips-linux-tdep.c $(defs_h) $(gdbcore_h) $(target_h) \
+ solib-svr4.h
+
mips-nat.o: mips-nat.c $(defs_h) $(gdbcore_h) $(inferior_h) $(regcache_h)
mips-tdep.o: mips-tdep.c $(defs_h) $(gdbcmd_h) $(gdbcore_h) \
@@ -2019,6 +2026,8 @@ source.o: source.c $(defs_h) $(expressio
$(gdbcore_h) $(language_h) $(objfiles_h) gdb_regex.h $(symfile_h) \
$(symtab_h) $(gdb_string_h) $(source_h) $(completer_h) $(linespec_h) \
$(ui_out_h)
+
+sparc-linux-nat.o: sparc-linux-nat.c $(defs_h) $(regcache_h)
sparc-nat.o: sparc-nat.c $(bfd_h) $(defs_h) $(inferior_h) $(gdbcore_h) \
$(target_h) $(regcache_h)
Index: config/sparc/linux.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/sparc/linux.mh,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -p -r1.3 -r1.4
--- linux.mh 2001/10/14 20:42:07 1.3
+++ linux.mh 2001/11/17 18:38:29 1.4
@@ -5,7 +5,7 @@ XDEPFILES=
NAT_FILE= nm-linux.h
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o sparc-nat.o \
- proc-service.o thread-db.o lin-lwp.o
+ proc-service.o thread-db.o lin-lwp.o sparc-linux-nat.o
# The dynamically loaded libthread_db needs access to symbols in the
# gdb executable.
/* Native-dependent code for Linux/SPARC.
Copyright 2001 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */
#include "defs.h"
#include "regcache.h"
#include <sys/procfs.h>
/* Prototypes for supply_gregset etc. */
#include "gregset.h"
void
supply_gregset (elf_gregset_t *gregsetp)
{
elf_greg_t *regp = (elf_greg_t *) gregsetp;
int i;
for (i = G0_REGNUM; i <= I7_REGNUM; i++)
supply_register (i, (char *) (regp + (i - G0_REGNUM)));
supply_register (PS_REGNUM, (char *) (regp + 32));
supply_register (PC_REGNUM, (char *) (regp + 33));
supply_register (NPC_REGNUM, (char *) (regp + 34));
supply_register (Y_REGNUM, (char *) (regp + 35));
supply_register (WIM_REGNUM, (char *) (regp + 36));
supply_register (TBR_REGNUM, (char *) (regp + 37));
/* Fill inaccessible registers with zero. */
supply_register (CPS_REGNUM, NULL);
}
void
fill_gregset (elf_gregset_t *gregsetp, int regno)
{
elf_greg_t *regp = (elf_greg_t *) gregsetp;
int i;
for (i = G0_REGNUM; i <= I7_REGNUM; i++)
if (regno == -1 || regno == i)
read_register_gen (i, (char *) (regp + (i - G0_REGNUM)));
if (regno == -1 || regno == PS_REGNUM)
read_register_gen (PS_REGNUM, (char *) (regp + 32));
if (regno == -1 || regno == PC_REGNUM)
read_register_gen (PC_REGNUM, (char *) (regp + 33));
if (regno == -1 || regno == NPC_REGNUM)
read_register_gen (NPC_REGNUM, (char *) (regp + 34));
if (regno == -1 || regno == Y_REGNUM)
read_register_gen (Y_REGNUM, (char *) (regp + 35));
if (regno == -1 || regno == WIM_REGNUM)
read_register_gen (WIM_REGNUM, (char *) (regp + 36));
if (regno == -1 || regno == TBR_REGNUM)
read_register_gen (TBR_REGNUM, (char *) (regp + 37));
}
void
supply_fpregset (elf_fpregset_t *fpregsetp)
{
int i;
for (i = FP0_REGNUM; i < FP0_REGNUM + 32; i++)
supply_register (i, (char *) &fpregsetp->pr_fr.pr_regs[i - FP0_REGNUM]);
supply_register (FPS_REGNUM, (char *) &fpregsetp->pr_fsr);
}
void
fill_fpregset (elf_fpregset_t *fpregsetp, int regno)
{
int i;
for (i = FP0_REGNUM; i < FP0_REGNUM + 32; i++)
if (regno == -1 || regno == i)
read_register_gen (i, (char *) &fpregsetp->pr_fr.pr_regs[i - FP0_REGNUM]);
if (regno == -1 || regno == FPS_REGNUM)
read_register_gen (FPS_REGNUM, (char *) &fpregsetp->pr_fsr);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fixing Linux/SPARC
2001-11-07 7:12 ` Daniel Jacobowitz
@ 2001-11-07 9:22 ` Andrew Cagney
2001-11-07 16:06 ` Daniel Jacobowitz
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cagney @ 2001-11-07 9:22 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: Mark Kettenis, gdb
> On Wed, Oct 17, 2001 at 04:07:52PM +0200, Mark Kettenis wrote:
>
>> Hi Dan & other interested folks,
>>
>> Something like the code below (completely untested, probably doesn't
>> even compile) is needed to fix Linux/SPARC.
>
>
> Compiles, after fixing the obvious typos. I'm going to commit it to
> the mainline as obvious, since it takes Linux/SPARC from not-building
> to building; test results are abysmal, though. It looks as if we can't
> figure out the memory location variables are stored at correctly.
> They're being accessed in the unmapped 0x90000000 segment instead of
> 0x70000000, and not even at the right offsets. I'll look in to it more
> later.
Dan, can you please replace the calls to read_register_gen() with
regcache_collect().
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fixing Linux/SPARC
2001-11-07 9:22 ` Andrew Cagney
@ 2001-11-07 16:06 ` Daniel Jacobowitz
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Jacobowitz @ 2001-11-07 16:06 UTC (permalink / raw)
To: Andrew Cagney; +Cc: Mark Kettenis, gdb
On Sat, Nov 17, 2001 at 02:18:42PM -0500, Andrew Cagney wrote:
> >On Wed, Oct 17, 2001 at 04:07:52PM +0200, Mark Kettenis wrote:
> >
> >>Hi Dan & other interested folks,
> >>
> >>Something like the code below (completely untested, probably doesn't
> >>even compile) is needed to fix Linux/SPARC.
> >
> >
> >Compiles, after fixing the obvious typos. I'm going to commit it to
> >the mainline as obvious, since it takes Linux/SPARC from not-building
> >to building; test results are abysmal, though. It looks as if we can't
> >figure out the memory location variables are stored at correctly.
> >They're being accessed in the unmapped 0x90000000 segment instead of
> >0x70000000, and not even at the right offsets. I'll look in to it more
> >later.
>
> Dan, can you please replace the calls to read_register_gen() with
> regcache_collect().
Done.
Threads don't work on Sparc still, because prgregset_t is much smaller
than an elf_gregset_t, so we corrupt memory in thread_db_fetch_registers.
You know by now what my opinion of this problem is :)
It appears that, for Sparc at least, this was fixed on:
2000-03-21 Jakub Jelinek <jakub@redhat.com>
My Sparc test machine runs a glibc older than that. I'd like to to
come up with some autoconf test to either not compile at all when this
bug is present, disable thread support, or compile in some hack to make
the type the right size. Any objection?
Actually, gross as it may be, something like this in thread-db.c ought
to do the trick:
union big_enough_gregset_t {
prgregset_t p;
gdb_gregset_t g;
};
and replacing uses of the prgregset with uses of big_enough_gregset_t.p
should fix the warnings without any autoconf checks. How's that sound?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
2001-11-17 Daniel Jacobowitz <drow@mvista.com>
* sparc-linux-nat.c (fill_gregset): Replace read_register_gen
with regcache_collect.
(fill_fpregset): Likewise.
Index: sparc-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/sparc-linux-nat.c,v
retrieving revision 1.1
diff -u -p -r1.1 sparc-linux-nat.c
--- sparc-linux-nat.c 2001/11/17 18:38:29 1.1
+++ sparc-linux-nat.c 2001/11/17 20:18:40
@@ -56,22 +56,22 @@ fill_gregset (elf_gregset_t *gregsetp, i
for (i = G0_REGNUM; i <= I7_REGNUM; i++)
if (regno == -1 || regno == i)
- read_register_gen (i, (char *) (regp + (i - G0_REGNUM)));
+ regcache_collect (i, regp + (i - G0_REGNUM));
if (regno == -1 || regno == PS_REGNUM)
- read_register_gen (PS_REGNUM, (char *) (regp + 32));
+ regcache_collect (PS_REGNUM, regp + 32);
if (regno == -1 || regno == PC_REGNUM)
- read_register_gen (PC_REGNUM, (char *) (regp + 33));
+ regcache_collect (PC_REGNUM, regp + 33);
if (regno == -1 || regno == NPC_REGNUM)
- read_register_gen (NPC_REGNUM, (char *) (regp + 34));
+ regcache_collect (NPC_REGNUM, regp + 34);
if (regno == -1 || regno == Y_REGNUM)
- read_register_gen (Y_REGNUM, (char *) (regp + 35));
+ regcache_collect (Y_REGNUM, regp + 35);
if (regno == -1 || regno == WIM_REGNUM)
- read_register_gen (WIM_REGNUM, (char *) (regp + 36));
+ regcache_collect (WIM_REGNUM, regp + 36);
if (regno == -1 || regno == TBR_REGNUM)
- read_register_gen (TBR_REGNUM, (char *) (regp + 37));
+ regcache_collect (TBR_REGNUM, regp + 37);
}
void
@@ -92,8 +92,8 @@ fill_fpregset (elf_fpregset_t *fpregsetp
for (i = FP0_REGNUM; i < FP0_REGNUM + 32; i++)
if (regno == -1 || regno == i)
- read_register_gen (i, (char *) &fpregsetp->pr_fr.pr_regs[i - FP0_REGNUM]);
+ regcache_collect (i, &fpregsetp->pr_fr.pr_regs[i - FP0_REGNUM]);
if (regno == -1 || regno == FPS_REGNUM)
- read_register_gen (FPS_REGNUM, (char *) &fpregsetp->pr_fsr);
+ regcache_collect (FPS_REGNUM, &fpregsetp->pr_fsr);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2001-11-17 20:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-17 7:08 Fixing Linux/SPARC Mark Kettenis
2001-11-07 7:12 ` Daniel Jacobowitz
2001-11-07 9:22 ` Andrew Cagney
2001-11-07 16:06 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox