Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Fernando Nasser <fnasser@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Eli Zaretskii <eliz@is.elta.co.il>,
	gdb@sources.redhat.com, Corinna Vinschen <vinschen@cygnus.com>
Subject: Re: [rfc] Completion tests failing
Date: Thu, 27 Sep 2001 08:34:00 -0000	[thread overview]
Message-ID: <3BB345F9.9CC3B68@redhat.com> (raw)
In-Reply-To: <20010927103401.B19151@nevyn.them.org>

Daniel Jacobowitz wrote:
> 
> On Thu, Sep 27, 2001 at 08:00:40AM -0400, Fernando Nasser wrote:
> > Eli Zaretskii wrote:
> > >
> > > Given the recent changes to completion, I really don't see any sense
> > > in testing this.  I'd suggest to delete the test.
> >
> > OK with me.  We could also change it to accept the "t" completion
> > noted by Corinna.
> >
> > Daniel, are you sending in a patch?
> 
> Actually, before I send in a patch, I have a question.  I've found
> another completion bug.
> 
> I wanted to get a name that I knew would complete unambiguously, so I
> tried using '"break.', which ought to complete to '"break.c"'.  It
> completes instead to '"break.c ' - trailing space, no trailing quote.
> 
> Am I right about what ought to happen?  If so, I'll make this two
> testcases, one failing, and then try to fix it.
> 

I am not 100% sure of what was Eli's intention, but I guess we would 
need to add a test to add the closing quote if the filename started 
with quote.  (The space at the end seems normal as the completer has
found a "complete" completion (i.e., a full file name) already).

Eli is in another time zone, so we may have to wait until tomorrow
to hear from him.

Thanks for finding/fixing this.

Regards,
Fernando

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


  reply	other threads:[~2001-09-27  8:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-26 18:13 Daniel Jacobowitz
2001-09-26 18:26 ` Elena Zannoni
2001-09-26 18:42   ` Daniel Jacobowitz
2001-09-27  1:39 ` Eli Zaretskii
2001-09-27  5:05   ` Fernando Nasser
2001-09-27  7:29     ` Daniel Jacobowitz
2001-09-27  7:33     ` Daniel Jacobowitz
2001-09-27  8:34       ` Fernando Nasser [this message]
2001-09-27 10:01         ` Eli Zaretskii
2001-09-27 10:22         ` Daniel Jacobowitz
2001-09-27 12:08           ` Eli Zaretskii
2001-09-27 13:48             ` Fernando Nasser
2001-09-27 15:22               ` Daniel Jacobowitz
2001-09-27  8:36       ` Eli Zaretskii
2001-09-27 10:00         ` Daniel Jacobowitz
2001-09-27 12:07           ` Eli Zaretskii
2001-09-27 12:19             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BB345F9.9CC3B68@redhat.com \
    --to=fnasser@redhat.com \
    --cc=drow@mvista.com \
    --cc=eliz@is.elta.co.il \
    --cc=gdb@sources.redhat.com \
    --cc=vinschen@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox