Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb@sources.redhat.com
Subject: [rfc] Completion tests failing
Date: Wed, 26 Sep 2001 18:13:00 -0000	[thread overview]
Message-ID: <20010926211336.A31592@nevyn.them.org> (raw)

I don't like failing tests... especially ones that time out after absurd
periods of time.  So, I've been looking at the testsuite, particularly
completion.exp today.

The test failing for me right now is completion for 'p "a<tab>'.  The
comments, and the testsuite, say that this is a string literal and should
not be completed.  The code tries to complete it as a location, though, and
decides to run it through location_completer. make_symbol_completion_list
notices the stray ", and decides not to allow completion; but
make_source_files_completion_list does no such thing.

Which behavior would people prefer?  I can update the testsuite to match. 
I'd also like to add expressions like:

        -re "^p \"a\[^\"\]*\"$"     { fail "complete 'p \"a'" }

if it is not supposed to complete; that is, if gdb completes it to something
and supplies the trailing quote, fail now, instead of waiting for timeout
and failing the next dozen tests too.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


             reply	other threads:[~2001-09-26 18:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-26 18:13 Daniel Jacobowitz [this message]
2001-09-26 18:26 ` Elena Zannoni
2001-09-26 18:42   ` Daniel Jacobowitz
2001-09-27  1:39 ` Eli Zaretskii
2001-09-27  5:05   ` Fernando Nasser
2001-09-27  7:29     ` Daniel Jacobowitz
2001-09-27  7:33     ` Daniel Jacobowitz
2001-09-27  8:34       ` Fernando Nasser
2001-09-27 10:01         ` Eli Zaretskii
2001-09-27 10:22         ` Daniel Jacobowitz
2001-09-27 12:08           ` Eli Zaretskii
2001-09-27 13:48             ` Fernando Nasser
2001-09-27 15:22               ` Daniel Jacobowitz
2001-09-27  8:36       ` Eli Zaretskii
2001-09-27 10:00         ` Daniel Jacobowitz
2001-09-27 12:07           ` Eli Zaretskii
2001-09-27 12:19             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010926211336.A31592@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox