[cli] set <var_boolean> <tab>?

[cli] set <var_boolean> <tab>?

[Andrew Cagney]

Hello,

While knocking up ``maint set profile'' I noticed that:

	maint set profile <tab>

(a cli var_boolean) doesn't do what I expected (it does nothing).  I was 
expecting behavour similar to the auto/boolean commands:

(gdb) set remote P-packet <tab>
auto  off   on
(gdb) set remote P-packet disable

Notice how while it suggests ``auto'', ``on'' or ``off'' it will accept 
almost anything.

To get ``maint set profile <tab>'' and other var_boolean commands 
providing similar behavour I just need to mimic what 
add_set_auto_boolean_cmd() does.  However, it begs a question.

I can either:

	o	Add a add_set_boolean_cmd() that is similar
		to add_set_auto_boolean_cmd()

	o	Tweek add_set_cmd() to realise it is
		a var_boolean and set things up accordingly.

If the latter, I should probably eliminate add_set_auto_boolean_cmd() 
and adding it to add_set_cmd().

so?
Andrew

Re: [cli] set <var_boolean> <tab>?

[Andrew Cagney]

> I can either:
> 
>     o    Add a add_set_boolean_cmd() that is similar
>         to add_set_auto_boolean_cmd()
> 
>     o    Tweek add_set_cmd() to realise it is
>         a var_boolean and set things up accordingly.
> 
> If the latter, I should probably eliminate add_set_auto_boolean_cmd() and adding it to add_set_cmd().

Closer inspection reveals the rationale.  add_set_auto_boolean_cmd takes 
an explicit / strongly typed ``enum cmd_auto_boolean'' as the parameter 
that is updated.  add_set_cmd() takes a ``void *''.  I'll cook up a 
patch adding add_set_boolean_cmd().

Andrew