Re: 4.17.86 on AIX 4.2.0.0 using IBM xlc

Re: 4.17.86 on AIX 4.2.0.0 using IBM xlc

[Andrew Cagney]

Andrew Cagney wrote:
> 
> rodneybrown@pmsc.com wrote:
> >
> > AIX 4.2.0.0 xlc gives an error for trailing commas in enum declarations
> > Specifically compiling gdb-4.17.86/gdb/blockframe.c it gives
> >
> > "gdb-4.17.86/gdb/target.h", line 57.22: 1506-046 (S) Syntax error.
> > "gdb-4.17.86/gdb/breakpoint.h", line 114.17: 1506-046 (S) Syntax error.
> 
> Thanks,

Hmm (is this a nightmare comming true?),

Looking at C manual:

6.5.2.2 Enumeration specifiers
Syntax
  enum-specifier:
    enum identifieropt { enumerator-list }
    enum identifieropt { enumerator-list , }
    enum identifier
  enumerator-list:
    enumerator
    enumerator-list , enumerator
  enumerator:
    enumeration-constant
    enumeration-constant = constant-expression

and the relevant line:

enum thread_control_capabilities {
        tc_none = 0,            /* Default: can't control thread
execution. */
        tc_schedlock = 1,       /* Can lock the thread scheduler. */
        tc_switch = 2,          /* Can switch the running thread on
demand. */
};

So, what to do about this one?

	Andrew

Re: 4.17.86 on AIX 4.2.0.0 using IBM xlc

[Andrew Cagney]

rodneybrown@pmsc.com wrote:
> 
> AIX 4.2.0.0 xlc gives an error for trailing commas in enum declarations
> Specifically compiling gdb-4.17.86/gdb/blockframe.c it gives
> 
> "gdb-4.17.86/gdb/target.h", line 57.22: 1506-046 (S) Syntax error.
> "gdb-4.17.86/gdb/breakpoint.h", line 114.17: 1506-046 (S) Syntax error.

Thanks,

	Andrew

4.17.86 on AIX 4.2.0.0 using IBM xlc

[rodneybrown]

AIX 4.2.0.0 xlc gives an error for trailing commas in enum declarations
Specifically compiling gdb-4.17.86/gdb/blockframe.c it gives

"gdb-4.17.86/gdb/target.h", line 57.22: 1506-046 (S) Syntax error.
"gdb-4.17.86/gdb/breakpoint.h", line 114.17: 1506-046 (S) Syntax error.

Re[2]: 4.17.86 on AIX 4.2.0.0 using IBM xlc

[rodneybrown]

For what it is worth the xlc lslpp information is

Fileset  Level  State Description
xlC.C    3.1.4.0  C   C for AIX Compiler


I note that my copy of the ANSI-C Standard
ISO/IEC 9899: 1990 Programming languages-C

doesn't have the trailing comma varient in section 6.5.2.2

A colleague notes that VMS Dec C gives a warning for the idiom.

____________________Reply Separator____________________
Subject:    Re: 4.17.86 on AIX 4.2.0.0 using IBM xlc 
Author: Andrew Cagney <ac131313@cygnus.com> 
Date:       17/03/99 19:24

Andrew Cagney wrote:
> 
> rodneybrown@pmsc.com wrote:
> >
> > AIX 4.2.0.0 xlc gives an error for trailing commas in enum declarations
> > Specifically compiling gdb-4.17.86/gdb/blockframe.c it gives
> >
> > "gdb-4.17.86/gdb/target.h", line 57.22: 1506-046 (S) Syntax error.
> > "gdb-4.17.86/gdb/breakpoint.h", line 114.17: 1506-046 (S) Syntax error.
> 
> Thanks,

Hmm (is this a nightmare comming true?),

Looking at C manual:

6.5.2.2 Enumeration specifiers
Syntax
  enum-specifier:
    enum identifieropt { enumerator-list }
    enum identifieropt { enumerator-list , }
    enum identifier
  enumerator-list:
    enumerator
    enumerator-list , enumerator
  enumerator:
    enumeration-constant
    enumeration-constant = constant-expression

and the relevant line:

enum thread_control_capabilities {
        tc_none = 0,            /* Default: can't control thread
execution. */
        tc_schedlock = 1,       /* Can lock the thread scheduler. */
        tc_switch = 2,          /* Can switch the running thread on
demand. */
};

So, what to do about this one?

        Andrew

Re: 4.17.86 on AIX 4.2.0.0 using IBM xlc

[Andrew Cagney]

rodneybrown@pmsc.com wrote:
> 
> For what it is worth the xlc lslpp information is
> 
> Fileset  Level  State Description
> xlC.C    3.1.4.0  C   C for AIX Compiler
> 
> I note that my copy of the ANSI-C Standard
> ISO/IEC 9899: 1990 Programming languages-C
> 
> doesn't have the trailing comma varient in section 6.5.2.2

Er, oops wrong ISO-C document, sorry.  Just pretend I didn't post that
:-)

Assuming that you're GPL assigned, would you be able to investigate the
compile problems using the AIX compiler?

	Andrew

Re: 4.17.86 on AIX 4.2.0.0 using IBM xlc

[Andrew Cagney]

Stan Shebs wrote:
> I assumed those two trailers were the only mistakes and already
> committed the fixes.  Any other such mistakes would likely have been
> fixed long ago, because of previous xlc or other compiler runs - these
> two enums were recently introduced/modified.

I'm not sure what you're asking here.

That code has always compliled with GCC.  What is new is that the
4.17.86 smap is being exposed to the wims of XLC (a different ISO-C
compiler).

I can probably dig up an AIX box with XLC and work through the errors it
produces.  However, if someone else can report back on XLC (with a
patch) it is going to happen much quicker.

	enjoy,
		Andrew

Re: 4.17.86 on AIX 4.2.0.0 using IBM xlc

[Stan Shebs]

   Date: Wed, 24 Mar 1999 16:37:51 +1100
   From: Andrew Cagney <ac131313@cygnus.com>

   Stan Shebs wrote:
   > I assumed those two trailers were the only mistakes and already
   > committed the fixes.  Any other such mistakes would likely have been
   > fixed long ago, because of previous xlc or other compiler runs - these
   > two enums were recently introduced/modified.

   I'm not sure what you're asking here.

   That code has always compliled with GCC.  What is new is that the
   4.17.86 smap is being exposed to the wims of XLC (a different ISO-C
   compiler).

Actually - everybody hold on to your hats - this isn't the first time
that GDB has been compiled with compilers other than GCC. :-)  The
official expectation is that GDB is portable C code, and that it can
be compiled and built by any reasonable C compiler.

   I can probably dig up an AIX box with XLC and work through the errors it
   produces.  However, if someone else can report back on XLC (with a
   patch) it is going to happen much quicker.

Yes.  To be honest, testing GDB with every possible compiler is not a
good use of Cygnus maintainers' time, so I'd prefer to rely on our
esteemed volunteers for this kind of testing (and indeed they've been
doing a great job of catching mistakes, thanks folks!)

								Stan

Re: 4.17.86 on AIX 4.2.0.0 using IBM xlc

[Stan Shebs]

   Date: Wed, 24 Mar 1999 10:05:07 +1100
   From: Andrew Cagney <ac131313@cygnus.com>

   Assuming that you're GPL assigned, would you be able to investigate the
   compile problems using the AIX compiler?

I assumed those two trailers were the only mistakes and already
committed the fixes.  Any other such mistakes would likely have been
fixed long ago, because of previous xlc or other compiler runs - these
two enums were recently introduced/modified.

							Stan