Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Dave Martin <Dave.Martin@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Edmund Grimley-Evans <Edmund.Grimley-Evans@arm.com>,
	libc-alpha@sourceware.org, gdb@sourceware.org
Subject: Re: [RFC PATCH v2 1/2] ARM: iwmmxt: Add missing __user annotations to sigframe accessors
Date: Tue, 27 Jun 2017 22:06:00 -0000	[thread overview]
Message-ID: <20170627220550.GS4902@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1498583067-14178-2-git-send-email-Dave.Martin@arm.com>

On Tue, Jun 27, 2017 at 06:04:06PM +0100, Dave Martin wrote:
> preserve_iwmmxt_context() and restore_iwmmxt_context() lack __user
> accessors on their arguments pointing to the user signal frame.
> 
> There does not be appear to be a bug here, but this omission is
> inconsistent with the crunch and vfp sigframe access functions.
> 
> This patch adds the annotations, for consistency.
> 
> Signed-off-by: Dave Martin <Dave.Martin@arm.com>

Absolutely the right thing to do.  Please drop this into the patch system,
thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.


  reply	other threads:[~2017-06-27 22:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 17:05 [RFC PATCH v2 0/2] ARM: Fix unparseable signal frame with CONFIG_IWMMXT Dave Martin
2017-06-27 17:05 ` [RFC PATCH v2 1/2] ARM: iwmmxt: Add missing __user annotations to sigframe accessors Dave Martin
2017-06-27 22:06   ` Russell King - ARM Linux [this message]
2017-06-27 17:05 ` [RFC PATCH v2 2/2] ARM: signal: Fix unparseable iwmmxt_sigframe in uc_regspace[] Dave Martin
2017-06-27 22:08   ` Russell King - ARM Linux
2017-06-28 13:09     ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170627220550.GS4902@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=Dave.Martin@arm.com \
    --cc=Edmund.Grimley-Evans@arm.com \
    --cc=gdb@sourceware.org \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox