From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97249 invoked by alias); 27 Jun 2017 22:06:03 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 96697 invoked by uid 89); 27 Jun 2017 22:06:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 spammy= X-HELO: pandora.armlinux.org.uk Received: from pandora.armlinux.org.uk (HELO pandora.armlinux.org.uk) (78.32.30.218) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 22:06:01 +0000 Received: from n2100.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:4f86]:45469) by pandora.armlinux.org.uk with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1dPycM-0003g2-73; Tue, 27 Jun 2017 23:05:54 +0100 Received: from linux by n2100.armlinux.org.uk with local (Exim 4.76) (envelope-from ) id 1dPycJ-0000UU-Ag; Tue, 27 Jun 2017 23:05:51 +0100 Date: Tue, 27 Jun 2017 22:06:00 -0000 From: Russell King - ARM Linux To: Dave Martin Cc: linux-arm-kernel@lists.infradead.org, Edmund Grimley-Evans , libc-alpha@sourceware.org, gdb@sourceware.org Subject: Re: [RFC PATCH v2 1/2] ARM: iwmmxt: Add missing __user annotations to sigframe accessors Message-ID: <20170627220550.GS4902@n2100.armlinux.org.uk> References: <1498583067-14178-1-git-send-email-Dave.Martin@arm.com> <1498583067-14178-2-git-send-email-Dave.Martin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498583067-14178-2-git-send-email-Dave.Martin@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2017-06/txt/msg00038.txt.bz2 On Tue, Jun 27, 2017 at 06:04:06PM +0100, Dave Martin wrote: > preserve_iwmmxt_context() and restore_iwmmxt_context() lack __user > accessors on their arguments pointing to the user signal frame. > > There does not be appear to be a bug here, but this omission is > inconsistent with the crunch and vfp sigframe access functions. > > This patch adds the annotations, for consistency. > > Signed-off-by: Dave Martin Absolutely the right thing to do. Please drop this into the patch system, thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.