Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Tim Newsome <tim@sifive.com>
Cc: Antoine Tremblay <antoine.tremblay@ericsson.com>,
	gdb <gdb@sourceware.org>
Subject: Re: read target register to decide breakpoint size
Date: Wed, 14 Dec 2016 09:18:00 -0000	[thread overview]
Message-ID: <20161214091811.GH25542@E107787-LIN> (raw)
In-Reply-To: <CAGDihemz5vACCHsxK6WtFOwPYhKr5h1-bU+yKLdvZqYgjGng6g@mail.gmail.com>

On 16-12-13 13:30:02, Tim Newsome wrote:
> Actually, this seems to work inside breakpoint_kind_from_pc():
> ```
>     struct frame_info *frame = get_current_frame ();
>     uint32_t misa = get_frame_register_unsigned (frame, RISCV_CSR_MISA_REGNUM);
> ```
> 
> Is that kosher? If so, is there any reason for me to implement
> breakpoint_kind_from_current_state?

I'd like not to do so.  Can't you decode the instruction to see whether
it is compressed or uncompressed?  I also think it is a good idea to
make a decision based on ELF info, as you mentioned in the first email.

-- 
Yao (齐尧)


  reply	other threads:[~2016-12-14  9:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 23:44 Tim Newsome
2016-11-19  1:16 ` Ofir Cohen
2016-11-21 16:37 ` Antoine Tremblay
2016-11-21 18:00   ` Tim Newsome
2016-12-13 20:58     ` Tim Newsome
2016-12-13 21:30       ` Tim Newsome
2016-12-14  9:18         ` Yao Qi [this message]
2016-12-14 12:32           ` Antoine Tremblay
2016-12-14 17:02             ` Tim Newsome
2016-12-14 17:22               ` Yao Qi
2016-12-14 18:15                 ` Antoine Tremblay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161214091811.GH25542@E107787-LIN \
    --to=qiyaoltc@gmail.com \
    --cc=antoine.tremblay@ericsson.com \
    --cc=gdb@sourceware.org \
    --cc=tim@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox