From: Joel Brobecker <brobecker@adacore.com>
To: Radjino Bholanath <R.M.R.Bholanath@student.tudelft.nl>
Cc: "gdb@sourceware.org" <gdb@sourceware.org>
Subject: Re: Questions about code reviews and static analysis tools for TU Delft research
Date: Wed, 25 Feb 2015 23:21:00 -0000 [thread overview]
Message-ID: <20150225075758.GC31802@adacore.com> (raw)
In-Reply-To: <016900840D5AC640A0034E24ACD7F2600EE1931B@SRV366.tudelft.net>
> 1. Do all developers (contributors and core developers) have to submit
> a code review for every change? I’m asking because many projects only
> review changes made by contributors.
Changes considered obvious do not need to be reviewed.
Nominated maintainers have the right to push a change without prior
review, but most submit the change and give others some time to comment
on it before doing the push.
In all cases, whether it be an immediate push without review or not,
the patch is always posted in the gdb-patches mailing-list.
> 2. Which code review tools are used?
There is no code-review tool used. Patches are reviewed by answer
the email that was used to submit the patch.
There is a patch tracking tool used by some maintainers.
> 3. Are static analyzers used? If they are used:
> a. Is passing the checks of the static analyzers necessary for a change to be accepted?
> b. Which static analyzers are used?
No static analysis tool used by the project per se. We had some
reports from the past sent to us; and, when appropriate, we made
some adjustments based on those reports.
--
Joel
next prev parent reply other threads:[~2015-02-25 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 10:54 Radjino Bholanath
2015-02-25 23:21 ` Joel Brobecker [this message]
2015-02-25 23:36 ` Radjino Bholanath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225075758.GC31802@adacore.com \
--to=brobecker@adacore.com \
--cc=R.M.R.Bholanath@student.tudelft.nl \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox