From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93417 invoked by alias); 25 Feb 2015 07:58:03 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 93398 invoked by uid 89); 25 Feb 2015 07:58:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 25 Feb 2015 07:58:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AC5D5116765; Wed, 25 Feb 2015 02:57:59 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AKQqn9M3Q-CP; Wed, 25 Feb 2015 02:57:59 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 58168116762; Wed, 25 Feb 2015 02:57:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 1518340EAD; Wed, 25 Feb 2015 08:57:58 +0100 (CET) Date: Wed, 25 Feb 2015 23:21:00 -0000 From: Joel Brobecker To: Radjino Bholanath Cc: "gdb@sourceware.org" Subject: Re: Questions about code reviews and static analysis tools for TU Delft research Message-ID: <20150225075758.GC31802@adacore.com> References: <016900840D5AC640A0034E24ACD7F2600EE1931B@SRV366.tudelft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <016900840D5AC640A0034E24ACD7F2600EE1931B@SRV366.tudelft.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-02/txt/msg00052.txt.bz2 > 1. Do all developers (contributors and core developers) have to submit > a code review for every change? I’m asking because many projects only > review changes made by contributors. Changes considered obvious do not need to be reviewed. Nominated maintainers have the right to push a change without prior review, but most submit the change and give others some time to comment on it before doing the push. In all cases, whether it be an immediate push without review or not, the patch is always posted in the gdb-patches mailing-list. > 2. Which code review tools are used? There is no code-review tool used. Patches are reviewed by answer the email that was used to submit the patch. There is a patch tracking tool used by some maintainers. > 3. Are static analyzers used? If they are used: > a. Is passing the checks of the static analyzers necessary for a change to be accepted? > b. Which static analyzers are used? No static analysis tool used by the project per se. We had some reports from the past sent to us; and, when appropriate, we made some adjustments based on those reports. -- Joel