Re: New format of 7.6 branch gdb/ChangeLog?

Re: New format of 7.6 branch gdb/ChangeLog?

[Joel Brobecker]

> "gdb/"
> Is this a new format of Changelog?  Do I need move changelog after it?

You are right, the "gdb/" shouldn't be there.

-- 
Joel

Re: New format of 7.6 branch gdb/ChangeLog?

[Hui Zhu]

On Thu, Apr 25, 2013 at 2:48 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> "gdb/"
>> Is this a new format of Changelog?  Do I need move changelog after it?
>
> You are right, the "gdb/" shouldn't be there.
>
> --
> Joel

It should be:
2013-04-19  Vladimir Kargov <kargov@gmail.com>
            Pedro Alves  <palves@redhat.com>

       gdb/
        * i387-tdep.c (i387_print_float_info): Use gdb_byte for pointer to
        value contents.

Right?

Thanks,
Hui

Re: New format of 7.6 branch gdb/ChangeLog?

[Joel Brobecker]

> It should be:
> 2013-04-19  Vladimir Kargov <kargov@gmail.com>
>             Pedro Alves  <palves@redhat.com>
> 
>        gdb/
>         * i387-tdep.c (i387_print_float_info): Use gdb_byte for pointer to
>         value contents.

No, the "gdb/" shouldn't be there either.

-- 
Joel

Re: New format of 7.6 branch gdb/ChangeLog?

[Hui Zhu]

On Thu, Apr 25, 2013 at 3:24 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> It should be:
>> 2013-04-19  Vladimir Kargov <kargov@gmail.com>
>>             Pedro Alves  <palves@redhat.com>
>>
>>        gdb/
>>         * i387-tdep.c (i387_print_float_info): Use gdb_byte for pointer to
>>         value contents.
>
> No, the "gdb/" shouldn't be there either.
>
> --
> Joel

It shoud like this?

gdb/
2013-04-24  Hui Zhu  <hui@codesourcery.com>

        PR gdb/15165

        * breakpoint.c (dprintf_print_recreate): New.
        (save_breakpoints): Let it not save dprintf commands.
        (initialize_breakpoint_ops): Set dprintf_print_recreate.

2013-04-19  Vladimir Kargov <kargov@gmail.com>
            Pedro Alves  <palves@redhat.com>

        * i387-tdep.c (i387_print_float_info): Use gdb_byte for pointer to
        value contents.

Thanks,
Hui

Re: New format of 7.6 branch gdb/ChangeLog?

[Joel Brobecker]

> It shoud like this?

I am referring you to the GNU Coding Standard manual:
http://www.gnu.org/prep/standards/standards.html#Change-Logs


> gdb/
> 2013-04-24  Hui Zhu  <hui@codesourcery.com>
> 
>         PR gdb/15165
> 
>         * breakpoint.c (dprintf_print_recreate): New.
>         (save_breakpoints): Let it not save dprintf commands.
>         (initialize_breakpoint_ops): Set dprintf_print_recreate.
> 
> 2013-04-19  Vladimir Kargov <kargov@gmail.com>
>             Pedro Alves  <palves@redhat.com>
> 
>         * i387-tdep.c (i387_print_float_info): Use gdb_byte for pointer to
>         value contents.

You put the "gdb/" back again. The correct answer is:

2013-04-24  Hui Zhu  <hui@codesourcery.com>

        PR gdb/15165
        * breakpoint.c (dprintf_print_recreate): New.
        (save_breakpoints): Let it not save dprintf commands.
        (initialize_breakpoint_ops): Set dprintf_print_recreate.

2013-04-19  Vladimir Kargov <kargov@gmail.com>
            Pedro Alves  <palves@redhat.com>

        * i387-tdep.c (i387_print_float_info): Use gdb_byte for pointer to
        value contents.

I removed the "gdb/" (which, if you think about it, provides no extra
information), and also removed the empty line after "PR gdb/...".

You probably got confused because people use the "gdb/" in their
email to specify which ChangeLog the entry is belonging to.

-- 
Joel

Re: New format of 7.6 branch gdb/ChangeLog?

[Hui Zhu]

On Thu, Apr 25, 2013 at 3:40 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> It shoud like this?
>
> I am referring you to the GNU Coding Standard manual:
> http://www.gnu.org/prep/standards/standards.html#Change-Logs
>
>
>> gdb/
>> 2013-04-24  Hui Zhu  <hui@codesourcery.com>
>>
>>         PR gdb/15165
>>
>>         * breakpoint.c (dprintf_print_recreate): New.
>>         (save_breakpoints): Let it not save dprintf commands.
>>         (initialize_breakpoint_ops): Set dprintf_print_recreate.
>>
>> 2013-04-19  Vladimir Kargov <kargov@gmail.com>
>>             Pedro Alves  <palves@redhat.com>
>>
>>         * i387-tdep.c (i387_print_float_info): Use gdb_byte for pointer to
>>         value contents.
>
> You put the "gdb/" back again. The correct answer is:
>
> 2013-04-24  Hui Zhu  <hui@codesourcery.com>
>
>         PR gdb/15165
>         * breakpoint.c (dprintf_print_recreate): New.
>         (save_breakpoints): Let it not save dprintf commands.
>         (initialize_breakpoint_ops): Set dprintf_print_recreate.
>
> 2013-04-19  Vladimir Kargov <kargov@gmail.com>
>             Pedro Alves  <palves@redhat.com>
>
>         * i387-tdep.c (i387_print_float_info): Use gdb_byte for pointer to
>         value contents.
>
> I removed the "gdb/" (which, if you think about it, provides no extra
> information), and also removed the empty line after "PR gdb/...".
>
> You probably got confused because people use the "gdb/" in their
> email to specify which ChangeLog the entry is belonging to.

I see.  Thanks for your help.
I fixed them all in
http://www.sourceware.org/ml/gdb-cvs/2013-04/msg00235.html
http://www.sourceware.org/ml/gdb-cvs/2013-04/msg00236.html

Best,
Hui

>
> --
> Joel

Re: New format of 7.6 branch gdb/ChangeLog?

[Pedro Alves]

Sorry, was on holiday yesterday.

On 04/25/2013 08:40 AM, Joel Brobecker wrote:

> I removed the "gdb/" (which, if you think about it, provides no extra
> information).

Thanks.  Indeed it was just a copy/paste-from-email error.

-- 
Pedro Alves