Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Joel Sherrill <joel.sherrill@oarcorp.com>,
	Mike Frysinger <vapier@gentoo.org>
Cc: "gdb@sourceware.org" <gdb@sourceware.org>,
	Chris Johns <chrisj@rtems.org>
Subject: Re: sim/erc32/Makefile.in patch - was Re: GDB 7.5.91 available for testing
Date: Wed, 13 Mar 2013 18:18:00 -0000	[thread overview]
Message-ID: <20130313181759.GN3162@adacore.com> (raw)
In-Reply-To: <5140904A.2040206@oarcorp.com>

> The sim/erc32 will not build outside the source tree. It is
> missing a -I. to find config.h in the build tree.
> 
> mkdir b--gdb
> cd b-gdb
> ../gdb-7.5.91/configure --target=sparc-rtems4.11 \
>    --prefix=/home/joel/test-gdb/install/ \
>    --enable-sim --enable-sim-hardware  \
>     --enable-timebase --enable-sim-trace >c.log 2>&1 && \
>     make >b.log 2>&1 && \
>    make install >i.log 2>&1
> 
> Should be enough to reproduce it.

Thanks. Reproduced using configure --target=sparc-elf --enable-sim.

> 2013-03-13  Joel Sherrill <joel.sherrill@oarcorp.com>
> 
>         * Makefile.in: Include build directory in search path to find
>         config.h

After a quick review of the patch, it looks reasonable to me.
But Mike F is the Global Maintainer, so I'll defer to him.

> 2013-03-13  Joel Sherrill <joel.sherrill@oarcorp.com>
> 
> 	* Makefile.in: Include build directory in search path to find
> 	config.h
> 
> Index: sim/erc32/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/sim/erc32/Makefile.in,v
> retrieving revision 1.12
> diff -u -r1.12 Makefile.in
> --- sim/erc32/Makefile.in	1 Jan 2013 06:41:35 -0000	1.12
> +++ sim/erc32/Makefile.in	13 Mar 2013 14:18:43 -0000
> @@ -45,7 +45,7 @@
>  # There is AC_C_BIGENDIAN but it doesn't handle float endianness.
>  # [Are int/float endians every different on a sparc?]
>  end: $(srcdir)/end.c
> -	$(CC_FOR_BUILD) $(srcdir)/end.c -o end
> +	$(CC_FOR_BUILD) -I. $(srcdir)/end.c -o end
>  end.h: end
>  	./end > end.h
>  


-- 
Joel


  reply	other threads:[~2013-03-13 18:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12 23:17 Joel Brobecker
2013-03-13 14:42 ` sim/erc32/Makefile.in patch - was " Joel Sherrill
2013-03-13 18:18   ` Joel Brobecker [this message]
2013-03-14 21:12     ` Mike Frysinger
     [not found] ` <5140894E.6000308@oarcorp.com>
2013-03-15 12:52   ` [gdb-7.5.91] mips sim fails to build on mingw32 Ralf Corsepius
2013-03-15 18:13     ` Mike Frysinger
2013-03-15 18:32       ` Ralf Corsepius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130313181759.GN3162@adacore.com \
    --to=brobecker@adacore.com \
    --cc=chrisj@rtems.org \
    --cc=gdb@sourceware.org \
    --cc=joel.sherrill@oarcorp.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox