From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17708 invoked by alias); 13 Mar 2013 18:18:11 -0000 Received: (qmail 17690 invoked by uid 22791); 13 Mar 2013 18:18:09 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 18:18:02 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8FD032E726; Wed, 13 Mar 2013 14:18:01 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7msVsyTQ43MT; Wed, 13 Mar 2013 14:18:01 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5DF612E1C3; Wed, 13 Mar 2013 14:18:01 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8DA20C0E4A; Wed, 13 Mar 2013 14:17:59 -0400 (EDT) Date: Wed, 13 Mar 2013 18:18:00 -0000 From: Joel Brobecker To: Joel Sherrill , Mike Frysinger Cc: "gdb@sourceware.org" , Chris Johns Subject: Re: sim/erc32/Makefile.in patch - was Re: GDB 7.5.91 available for testing Message-ID: <20130313181759.GN3162@adacore.com> References: <20130312231727.GF31629@adacore.com> <5140904A.2040206@oarcorp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5140904A.2040206@oarcorp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00011.txt.bz2 > The sim/erc32 will not build outside the source tree. It is > missing a -I. to find config.h in the build tree. > > mkdir b--gdb > cd b-gdb > ../gdb-7.5.91/configure --target=sparc-rtems4.11 \ > --prefix=/home/joel/test-gdb/install/ \ > --enable-sim --enable-sim-hardware \ > --enable-timebase --enable-sim-trace >c.log 2>&1 && \ > make >b.log 2>&1 && \ > make install >i.log 2>&1 > > Should be enough to reproduce it. Thanks. Reproduced using configure --target=sparc-elf --enable-sim. > 2013-03-13 Joel Sherrill > > * Makefile.in: Include build directory in search path to find > config.h After a quick review of the patch, it looks reasonable to me. But Mike F is the Global Maintainer, so I'll defer to him. > 2013-03-13 Joel Sherrill > > * Makefile.in: Include build directory in search path to find > config.h > > Index: sim/erc32/Makefile.in > =================================================================== > RCS file: /cvs/src/src/sim/erc32/Makefile.in,v > retrieving revision 1.12 > diff -u -r1.12 Makefile.in > --- sim/erc32/Makefile.in 1 Jan 2013 06:41:35 -0000 1.12 > +++ sim/erc32/Makefile.in 13 Mar 2013 14:18:43 -0000 > @@ -45,7 +45,7 @@ > # There is AC_C_BIGENDIAN but it doesn't handle float endianness. > # [Are int/float endians every different on a sparc?] > end: $(srcdir)/end.c > - $(CC_FOR_BUILD) $(srcdir)/end.c -o end > + $(CC_FOR_BUILD) -I. $(srcdir)/end.c -o end > end.h: end > ./end > end.h > -- Joel